From cbc2b9eb374a5787477a56e4fb7603aa0cbd8442 Mon Sep 17 00:00:00 2001 From: chenke Date: Tue, 6 Aug 2019 11:02:01 +0800 Subject: [PATCH] Fix var src_extra_specs error This error was discovered by tool coverity. If we don't initialize this var src_extra_specs, line 225 may sometimes raise an error. Change-Id: I992b56b64d56f35c8355b22707c3db5112964b31 --- .../strategy/strategies/storage_capacity_balance.py | 1 + 1 file changed, 1 insertion(+) diff --git a/watcher/decision_engine/strategy/strategies/storage_capacity_balance.py b/watcher/decision_engine/strategy/strategies/storage_capacity_balance.py index 648839b62..7fdf753d0 100644 --- a/watcher/decision_engine/strategy/strategies/storage_capacity_balance.py +++ b/watcher/decision_engine/strategy/strategies/storage_capacity_balance.py @@ -207,6 +207,7 @@ class StorageCapacityBalance(base.WorkloadStabilizationBaseStrategy): def check_pool_type(self, volume, dest_pool): target_type = None + src_extra_specs = {} # check type feature if not volume.volume_type: return target_type