Arnike/watcher
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Drop nova command reference from the code

Browse Source 
In DevStack environment, nova service-list command does not
exist. Distro suggests to install python-novaclient from package.

In Strategies documentation, we generate the docs from following
code.[1]
```
       * - ``migration``
         - .. watcher-term:: watcher.applier.actions.migration.Migrate
       * - ``change_nova_service_state``
         - .. watcher-term:: watcher.applier.actions.change_nova_service_state.ChangeNovaServiceState
```
and with in code, we use nova python binding to get list services[2]
and we are not calling openstack cli reference with in the code.

Documenting the equivalent openstack command does not seems to be useful
in the help text as we are using python binding.

Links:
[1]. c4acce91d6/doc/source/strategies/host_maintenance.rst (L45)
[2]. c4acce91d6/watcher/common/nova_helper.py (L150-L152)

Change-Id: I0c663c9741fae94bdb9c30f46d3d396325a33948
Signed-off-by: Chandan Kumar (raukadah) <chkumar@redhat.com>
This commit is contained in:
Chandan Kumar (raukadah)
2025-04-22 18:16:44 +05:30
parent adbcac9319
commit 3f6c7e406a
2 changed files with 3 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
watcher/applier/actions/change_nova_service_state.py
View File

@@ -39,10 +39,8 @@ class ChangeNovaServiceState(base.BaseAction):
'disabled_reason': str, 'disabled_reason': str,
}) })
The `resource_id` references a nova-compute service name (list of available The `resource_id` references a nova-compute service name.
nova-compute services is returned by this command: ``nova service-list The `state` value should either be `up` or `down`.
--binary nova-compute``).
The `state` value should either be `ONLINE` or `OFFLINE`.
The `disabled_reason` references the reason why Watcher disables this The `disabled_reason` references the reason why Watcher disables this
nova-compute service. The value should be with `watcher_` prefix, such as nova-compute service. The value should be with `watcher_` prefix, such as
`watcher_disabled`, `watcher_maintaining`. `watcher_disabled`, `watcher_maintaining`.

4
watcher/applier/actions/migration.py
View File

@@ -47,9 +47,7 @@ class Migrate(base.BaseAction):
The `resource_id` is the UUID of the server to migrate. The `resource_id` is the UUID of the server to migrate.
The `source_node` and `destination_node` parameters are respectively the The `source_node` and `destination_node` parameters are respectively the
source and the destination compute hostname (list of available compute source and the destination compute hostname.
hosts is returned by this command: ``nova service-list --binary
nova-compute``).
.. note:: .. note::