diff --git a/watcher/decision_engine/model/collector/nova.py b/watcher/decision_engine/model/collector/nova.py index e1b2c4a07..4ec1d1d40 100644 --- a/watcher/decision_engine/model/collector/nova.py +++ b/watcher/decision_engine/model/collector/nova.py @@ -361,9 +361,6 @@ class ModelBuilder(object): flavor = instance.flavor instance_attributes = { "uuid": instance.id, - # TODO(chenker) human_id is deprecated for removal. For the reason, - # please reference bug 1833665. - "human_id": instance.human_id, "name": instance.name, "memory": flavor["ram"], "disk": flavor["disk"], diff --git a/watcher/decision_engine/model/element/compute_resource.py b/watcher/decision_engine/model/element/compute_resource.py index 4b0348a02..4b9037506 100644 --- a/watcher/decision_engine/model/element/compute_resource.py +++ b/watcher/decision_engine/model/element/compute_resource.py @@ -29,5 +29,4 @@ class ComputeResource(base.Element): fields = { "uuid": wfields.StringField(), - "human_id": wfields.StringField(default=""), } diff --git a/watcher/decision_engine/model/notification/nova.py b/watcher/decision_engine/model/notification/nova.py index 9387ca1c1..4b246756d 100644 --- a/watcher/decision_engine/model/notification/nova.py +++ b/watcher/decision_engine/model/notification/nova.py @@ -74,9 +74,6 @@ class NovaNotification(base.NotificationEndpoint): instance.update({ 'state': instance_data['state'], 'hostname': instance_data['host_name'], - # TODO(chenker) human_id is deprecated for removal. For the reason, - # please reference bug 1833665. - 'human_id': instance_data['display_name'], # this is the user-provided display name of the server which is not # guaranteed to be unique nor is it immutable. 'name': instance_data['display_name'], diff --git a/watcher/tests/decision_engine/cluster/test_nova_cdmc.py b/watcher/tests/decision_engine/cluster/test_nova_cdmc.py index 55df67aec..e11786113 100644 --- a/watcher/tests/decision_engine/cluster/test_nova_cdmc.py +++ b/watcher/tests/decision_engine/cluster/test_nova_cdmc.py @@ -76,7 +76,6 @@ class TestNovaClusterDataModelCollector(base.TestCase): **minimal_node_with_servers) fake_instance = mock.Mock( id='ef500f7e-dac8-470f-960c-169486fce71b', - human_id='fake_instance', name='fake_instance', flavor={'ram': 333, 'disk': 222, 'vcpus': 4, 'id': 1}, metadata={'hi': 'hello'}, diff --git a/watcher/tests/decision_engine/model/data/scenario_1.xml b/watcher/tests/decision_engine/model/data/scenario_1.xml index 10c038e87..933399961 100644 --- a/watcher/tests/decision_engine/model/data/scenario_1.xml +++ b/watcher/tests/decision_engine/model/data/scenario_1.xml @@ -1,47 +1,47 @@ - - - + + + - - + + - - - - + + + + - - + + - - + + - - - - - - - - - - - - - - - - - - - - - - - - - - - + + + + + + + + + + + + + + + + + + + + + + + + + + + diff --git a/watcher/tests/decision_engine/model/data/scenario_1_with_1_node_unavailable.xml b/watcher/tests/decision_engine/model/data/scenario_1_with_1_node_unavailable.xml index 8477f743a..a0f3733ac 100644 --- a/watcher/tests/decision_engine/model/data/scenario_1_with_1_node_unavailable.xml +++ b/watcher/tests/decision_engine/model/data/scenario_1_with_1_node_unavailable.xml @@ -1,50 +1,50 @@ - - - + + + - - + + - - - - + + + + - - + + - - + + - - + + - - - - - - - - - - - - - - - - - - - - - - - - - - - + + + + + + + + + + + + + + + + + + + + + + + + + + + diff --git a/watcher/tests/decision_engine/model/data/scenario_1_with_all_instances_exclude.xml b/watcher/tests/decision_engine/model/data/scenario_1_with_all_instances_exclude.xml index b303f964c..515d93ca1 100644 --- a/watcher/tests/decision_engine/model/data/scenario_1_with_all_instances_exclude.xml +++ b/watcher/tests/decision_engine/model/data/scenario_1_with_all_instances_exclude.xml @@ -1,47 +1,47 @@ - - - + + + - - + + - - - - + + + + - - + + - - + + - - - - - - - - - - - - - - - - - - - - - - - - - - - + + + + + + + + + + + + + + + + + + + + + + + + + + + diff --git a/watcher/tests/decision_engine/model/data/scenario_1_with_all_nodes_disable.xml b/watcher/tests/decision_engine/model/data/scenario_1_with_all_nodes_disable.xml index 1fc05962a..a2f9ea2a9 100644 --- a/watcher/tests/decision_engine/model/data/scenario_1_with_all_nodes_disable.xml +++ b/watcher/tests/decision_engine/model/data/scenario_1_with_all_nodes_disable.xml @@ -1,9 +1,9 @@ - - + + - - + + diff --git a/watcher/tests/decision_engine/model/data/scenario_1_with_metrics.xml b/watcher/tests/decision_engine/model/data/scenario_1_with_metrics.xml index eee2be8a3..0b21467f3 100644 --- a/watcher/tests/decision_engine/model/data/scenario_1_with_metrics.xml +++ b/watcher/tests/decision_engine/model/data/scenario_1_with_metrics.xml @@ -1,8 +1,8 @@ - - + + - - + + diff --git a/watcher/tests/decision_engine/model/data/scenario_2_with_metrics.xml b/watcher/tests/decision_engine/model/data/scenario_2_with_metrics.xml index d3ffc115b..3be1130e0 100644 --- a/watcher/tests/decision_engine/model/data/scenario_2_with_metrics.xml +++ b/watcher/tests/decision_engine/model/data/scenario_2_with_metrics.xml @@ -1,13 +1,13 @@ - - - - - - - + + + + + + + - - - + + + diff --git a/watcher/tests/decision_engine/model/data/scenario_3_with_2_nodes.xml b/watcher/tests/decision_engine/model/data/scenario_3_with_2_nodes.xml index 03074052d..2433318e1 100644 --- a/watcher/tests/decision_engine/model/data/scenario_3_with_2_nodes.xml +++ b/watcher/tests/decision_engine/model/data/scenario_3_with_2_nodes.xml @@ -1,8 +1,8 @@ - - + + - - + + diff --git a/watcher/tests/decision_engine/model/data/scenario_3_with_metrics.xml b/watcher/tests/decision_engine/model/data/scenario_3_with_metrics.xml index c4311a42f..192357d3a 100644 --- a/watcher/tests/decision_engine/model/data/scenario_3_with_metrics.xml +++ b/watcher/tests/decision_engine/model/data/scenario_3_with_metrics.xml @@ -1,9 +1,9 @@ - - - - - + + + + + - + diff --git a/watcher/tests/decision_engine/model/data/scenario_4_with_1_node_no_instance.xml b/watcher/tests/decision_engine/model/data/scenario_4_with_1_node_no_instance.xml index c3a7e4358..722b59250 100644 --- a/watcher/tests/decision_engine/model/data/scenario_4_with_1_node_no_instance.xml +++ b/watcher/tests/decision_engine/model/data/scenario_4_with_1_node_no_instance.xml @@ -1,3 +1,3 @@ - + diff --git a/watcher/tests/decision_engine/model/data/scenario_5_with_instance_disk_0.xml b/watcher/tests/decision_engine/model/data/scenario_5_with_instance_disk_0.xml index 55a36548b..333465068 100644 --- a/watcher/tests/decision_engine/model/data/scenario_5_with_instance_disk_0.xml +++ b/watcher/tests/decision_engine/model/data/scenario_5_with_instance_disk_0.xml @@ -1,5 +1,5 @@ - - + + diff --git a/watcher/tests/decision_engine/model/data/scenario_6_with_2_nodes.xml b/watcher/tests/decision_engine/model/data/scenario_6_with_2_nodes.xml index 0ba822dba..83189fc32 100644 --- a/watcher/tests/decision_engine/model/data/scenario_6_with_2_nodes.xml +++ b/watcher/tests/decision_engine/model/data/scenario_6_with_2_nodes.xml @@ -1,10 +1,10 @@ - - - + + + - - - + + + diff --git a/watcher/tests/decision_engine/model/data/scenario_7_with_2_nodes.xml b/watcher/tests/decision_engine/model/data/scenario_7_with_2_nodes.xml index c6e77c25d..66cd8da01 100644 --- a/watcher/tests/decision_engine/model/data/scenario_7_with_2_nodes.xml +++ b/watcher/tests/decision_engine/model/data/scenario_7_with_2_nodes.xml @@ -1,10 +1,10 @@ - - - + + + - - - + + + diff --git a/watcher/tests/decision_engine/model/data/scenario_8_with_4_nodes.xml b/watcher/tests/decision_engine/model/data/scenario_8_with_4_nodes.xml index 3eca87391..91bf4bf56 100644 --- a/watcher/tests/decision_engine/model/data/scenario_8_with_4_nodes.xml +++ b/watcher/tests/decision_engine/model/data/scenario_8_with_4_nodes.xml @@ -1,16 +1,16 @@ - - - - + + + + - - + + - - + + - - + + diff --git a/watcher/tests/decision_engine/model/data/scenario_9_with_3_active_plus_1_disabled_nodes.xml b/watcher/tests/decision_engine/model/data/scenario_9_with_3_active_plus_1_disabled_nodes.xml index 73da7f2c4..bdc602a0d 100644 --- a/watcher/tests/decision_engine/model/data/scenario_9_with_3_active_plus_1_disabled_nodes.xml +++ b/watcher/tests/decision_engine/model/data/scenario_9_with_3_active_plus_1_disabled_nodes.xml @@ -1,16 +1,16 @@ - - - - + + + + - - + + - - + + - - + + diff --git a/watcher/tests/decision_engine/model/test_element.py b/watcher/tests/decision_engine/model/test_element.py index 7da704fdd..93ff6936a 100644 --- a/watcher/tests/decision_engine/model/test_element.py +++ b/watcher/tests/decision_engine/model/test_element.py @@ -29,7 +29,6 @@ class TestElement(base.TestCase): 'uuid': 'FAKE_UUID', 'state': 'state', 'hostname': 'hostname', - 'human_id': 'human_id', 'memory': 111, 'vcpus': 222, 'disk': 333, @@ -50,7 +49,6 @@ class TestElement(base.TestCase): 'uuid': 'FAKE_UUID', 'state': 'state', 'hostname': 'hostname', - 'human_id': 'human_id', 'name': 'name', 'memory': 111, 'vcpus': 222,