From 8401b5e4794d99d1e5948669898fc668b1d5c969 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Vincent=20Fran=C3=A7oise?= Date: Mon, 23 May 2016 14:23:56 +0200 Subject: [PATCH] Fixed flaky tempest test In this changeset, I fixed the test_create_audit_with_no_state tempest test which was randomly failing because of a race condition. Change-Id: Ibda49944c79fcd406fa81870dbbff6064b5dc4fa --- watcher_tempest_plugin/tests/api/admin/test_audit.py | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/watcher_tempest_plugin/tests/api/admin/test_audit.py b/watcher_tempest_plugin/tests/api/admin/test_audit.py index 408eaaed0..6d7991842 100644 --- a/watcher_tempest_plugin/tests/api/admin/test_audit.py +++ b/watcher_tempest_plugin/tests/api/admin/test_audit.py @@ -25,6 +25,9 @@ from watcher_tempest_plugin.tests.api.admin import base class TestCreateUpdateDeleteAudit(base.BaseInfraOptimTest): """Tests for audit.""" + audit_states = ['ONGOING', 'SUCCEEDED', 'SUBMITTED', 'FAILED', + 'CANCELLED', 'DELETED', 'PENDING'] + def assert_expected(self, expected, actual, keys=('created_at', 'updated_at', 'deleted_at', 'state')): @@ -102,7 +105,7 @@ class TestCreateUpdateDeleteAudit(base.BaseInfraOptimTest): _, audit = self.client.show_audit(body['uuid']) initial_audit_state = audit.pop('state') - self.assertEqual('PENDING', initial_audit_state) + self.assertIn(initial_audit_state, self.audit_states) self.assert_expected(audit, body)