Revert "Don't revert Migrate action"
Whether to revert migrate action when the action_plan fails is determained by 'rollback_actionplan' option.
This reverts commit c522e881b1.
Change-Id: I5379018b7838dff4caf0ee0ce06cfa32e7b37b12
This commit is contained in:
@@ -186,7 +186,7 @@ class Migrate(base.BaseAction):
|
|||||||
return self.migrate(destination=self.destination_node)
|
return self.migrate(destination=self.destination_node)
|
||||||
|
|
||||||
def revert(self):
|
def revert(self):
|
||||||
LOG.info('Migrate action do not revert!')
|
return self.migrate(destination=self.source_node)
|
||||||
|
|
||||||
def abort(self):
|
def abort(self):
|
||||||
nova = nova_helper.NovaHelper(osc=self.osc)
|
nova = nova_helper.NovaHelper(osc=self.osc)
|
||||||
|
|||||||
@@ -187,6 +187,29 @@ class TestMigration(base.TestCase):
|
|||||||
dest_hostname="compute2-hostname"
|
dest_hostname="compute2-hostname"
|
||||||
)
|
)
|
||||||
|
|
||||||
|
def test_revert_live_migration(self):
|
||||||
|
self.m_helper.find_instance.return_value = self.INSTANCE_UUID
|
||||||
|
|
||||||
|
self.action.revert()
|
||||||
|
|
||||||
|
self.m_helper_cls.assert_called_once_with(osc=self.m_osc)
|
||||||
|
self.m_helper.live_migrate_instance.assert_called_once_with(
|
||||||
|
instance_id=self.INSTANCE_UUID,
|
||||||
|
dest_hostname="compute1-hostname"
|
||||||
|
)
|
||||||
|
|
||||||
|
def test_revert_cold_migration(self):
|
||||||
|
self.m_helper.find_instance.return_value = self.INSTANCE_UUID
|
||||||
|
|
||||||
|
self.action_cold.revert()
|
||||||
|
|
||||||
|
self.m_helper_cls.assert_called_once_with(osc=self.m_osc)
|
||||||
|
self.m_helper.watcher_non_live_migrate_instance.\
|
||||||
|
assert_called_once_with(
|
||||||
|
instance_id=self.INSTANCE_UUID,
|
||||||
|
dest_hostname="compute1-hostname"
|
||||||
|
)
|
||||||
|
|
||||||
def test_abort_live_migrate(self):
|
def test_abort_live_migrate(self):
|
||||||
migration = mock.MagicMock()
|
migration = mock.MagicMock()
|
||||||
migration.id = "2"
|
migration.id = "2"
|
||||||
|
|||||||
Reference in New Issue
Block a user