From 5c7fcc22c098cc63b960c3b8a545686d627ec79a Mon Sep 17 00:00:00 2001 From: Guang Yee Date: Mon, 16 Sep 2019 10:33:36 -0700 Subject: [PATCH] fix test failure with ironic client The watcher.tests.common.test_clients.TestClients.test_clients_ironic unit test's been failure since python-ironicclient 2.5.2 release. In that release, we fixed a bug with the interface argument was ignored. https://docs.openstack.org/releasenotes/python-ironicclient/rocky.html#relnotes-2-5-2-stable-rocky Therefore, we need to adjust the ironic test case in watcher to account for the interface argument. Change-Id: Iedb27efc9f296054fcbd485b27736a789cee3496 --- watcher/tests/common/test_clients.py | 1 + 1 file changed, 1 insertion(+) diff --git a/watcher/tests/common/test_clients.py b/watcher/tests/common/test_clients.py index 8010a3b69..1200579e8 100755 --- a/watcher/tests/common/test_clients.py +++ b/watcher/tests/common/test_clients.py @@ -410,6 +410,7 @@ class TestClients(base.TestCase): mock_call.assert_called_once_with( CONF.ironic_client.api_version, endpoint_override=ironic_url, + interface='publicURL', max_retries=None, os_ironic_api_version=None, retry_interval=None,