diff --git a/watcher/decision_engine/audit/base.py b/watcher/decision_engine/audit/base.py index cccb1aaef..11ad80e06 100644 --- a/watcher/decision_engine/audit/base.py +++ b/watcher/decision_engine/audit/base.py @@ -96,9 +96,10 @@ class AuditHandler(BaseAuditHandler): raise def update_audit_state(self, audit, state): - LOG.debug("Update audit state: %s", state) - audit.state = state - audit.save() + if audit.state != state: + LOG.debug("Update audit state: %s", state) + audit.state = state + audit.save() def check_ongoing_action_plans(self, request_context): a_plan_filters = {'state': objects.action_plan.State.ONGOING} diff --git a/watcher/tests/decision_engine/audit/test_audit_handlers.py b/watcher/tests/decision_engine/audit/test_audit_handlers.py index 80ea326de..8e7d084ac 100644 --- a/watcher/tests/decision_engine/audit/test_audit_handlers.py +++ b/watcher/tests/decision_engine/audit/test_audit_handlers.py @@ -338,8 +338,6 @@ class TestContinuousAuditHandler(base.DbTestCase): mock_jobs.return_value = mock.MagicMock() m_service.return_value = mock.MagicMock() m_engine.return_value = mock.MagicMock() - self.audits[1].state = objects.audit.State.CANCELLED - self.audits[0].state = objects.audit.State.SUSPENDED ap_jobs = [job.Job(mock.MagicMock(), name='execute_audit', func=audit_handler.execute_audit,