From 80e8d0002a0690f5eb52cb105ddea9955f5138bb Mon Sep 17 00:00:00 2001 From: Dantali0n Date: Thu, 11 Jul 2019 14:54:04 +0200 Subject: [PATCH] Resolve aggregate error in workload_stabilization This error is caused because the condition "is not '':" is not always true. Sometimes self.aggregation_method['node'] is u'' instead of ''. This patch ensures that in both cases the behavior is the same. Change-Id: I7453678cc76892ebeacca23c3501a10a08725d1d Closes-bug: #1836195 --- .../strategy/strategies/workload_stabilization.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/watcher/decision_engine/strategy/strategies/workload_stabilization.py b/watcher/decision_engine/strategy/strategies/workload_stabilization.py index 1904fad7a..8e6804cd2 100644 --- a/watcher/decision_engine/strategy/strategies/workload_stabilization.py +++ b/watcher/decision_engine/strategy/strategies/workload_stabilization.py @@ -507,7 +507,7 @@ class WorkloadStabilization(base.WorkloadStabilizationBaseStrategy): self.aggregation_method = self.input_parameters.aggregation_method # backwards compatibility for node parameter with aggregate. - if self.aggregation_method['node'] is not '': + if self.aggregation_method['node']: LOG.warning('Parameter node has been renamed to compute_node and ' 'will be removed in next release.') self.aggregation_method['compute_node'] = \