Arnike/watcher
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Use Property setters

Browse Source 
At various places in watcher code, we are using property getters
to set property, in this way the property setters defined are
never used, this patch fixes to use property setters to set
property.

Change-Id: Idb274887f383523cea39277b166ec9b46ebcda85
This commit is contained in:
aditi
2017-09-27 10:41:19 +09:00
parent 773b20a05f
commit 8e89d5489c
7 changed files with 15 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
watcher/decision_engine/strategy/strategies/basic_consolidation.py
View File

@@ -170,7 +170,7 @@ class BasicConsolidation(base.ServerConsolidationBaseStrategy):
@property @property
def ceilometer(self): def ceilometer(self):
if self._ceilometer is None: if self._ceilometer is None:
self._ceilometer = ceil.CeilometerHelper(osc=self.osc) self.ceilometer = ceil.CeilometerHelper(osc=self.osc)
return self._ceilometer return self._ceilometer
@ceilometer.setter @ceilometer.setter
@@ -180,7 +180,7 @@ class BasicConsolidation(base.ServerConsolidationBaseStrategy):
@property @property
def monasca(self): def monasca(self):
if self._monasca is None: if self._monasca is None:
self._monasca = mon.MonascaHelper(osc=self.osc) self.monasca = mon.MonascaHelper(osc=self.osc)
return self._monasca return self._monasca
@monasca.setter @monasca.setter
@@ -190,7 +190,7 @@ class BasicConsolidation(base.ServerConsolidationBaseStrategy):
@property @property
def gnocchi(self): def gnocchi(self):
if self._gnocchi is None: if self._gnocchi is None:
self._gnocchi = gnoc.GnocchiHelper(osc=self.osc) self.gnocchi = gnoc.GnocchiHelper(osc=self.osc)
return self._gnocchi return self._gnocchi
@gnocchi.setter @gnocchi.setter

2
watcher/decision_engine/strategy/strategies/noisy_neighbor.py
View File

@@ -50,7 +50,7 @@ class NoisyNeighbor(base.NoisyNeighborBaseStrategy):
@property @property
def ceilometer(self): def ceilometer(self):
if self._ceilometer is None: if self._ceilometer is None:
self._ceilometer = ceil.CeilometerHelper(osc=self.osc) self.ceilometer = ceil.CeilometerHelper(osc=self.osc)
return self._ceilometer return self._ceilometer
@ceilometer.setter @ceilometer.setter

4
watcher/decision_engine/strategy/strategies/outlet_temp_control.py
View File

@@ -140,7 +140,7 @@ class OutletTempControl(base.ThermalOptimizationBaseStrategy):
@property @property
def ceilometer(self): def ceilometer(self):
if self._ceilometer is None: if self._ceilometer is None:
self._ceilometer = ceil.CeilometerHelper(osc=self.osc) self.ceilometer = ceil.CeilometerHelper(osc=self.osc)
return self._ceilometer return self._ceilometer
@ceilometer.setter @ceilometer.setter
@@ -150,7 +150,7 @@ class OutletTempControl(base.ThermalOptimizationBaseStrategy):
@property @property
def gnocchi(self): def gnocchi(self):
if self._gnocchi is None: if self._gnocchi is None:
self._gnocchi = gnoc.GnocchiHelper(osc=self.osc) self.gnocchi = gnoc.GnocchiHelper(osc=self.osc)
return self._gnocchi return self._gnocchi
@gnocchi.setter @gnocchi.setter

4
watcher/decision_engine/strategy/strategies/uniform_airflow.py
View File

@@ -130,7 +130,7 @@ class UniformAirflow(base.BaseStrategy):
@property @property
def ceilometer(self): def ceilometer(self):
if self._ceilometer is None: if self._ceilometer is None:
self._ceilometer = ceil.CeilometerHelper(osc=self.osc) self.ceilometer = ceil.CeilometerHelper(osc=self.osc)
return self._ceilometer return self._ceilometer
@ceilometer.setter @ceilometer.setter
@@ -140,7 +140,7 @@ class UniformAirflow(base.BaseStrategy):
@property @property
def gnocchi(self): def gnocchi(self):
if self._gnocchi is None: if self._gnocchi is None:
self._gnocchi = gnoc.GnocchiHelper(osc=self.osc) self.gnocchi = gnoc.GnocchiHelper(osc=self.osc)
return self._gnocchi return self._gnocchi
@gnocchi.setter @gnocchi.setter

4
watcher/decision_engine/strategy/strategies/vm_workload_consolidation.py
View File

@@ -118,7 +118,7 @@ class VMWorkloadConsolidation(base.ServerConsolidationBaseStrategy):
@property @property
def ceilometer(self): def ceilometer(self):
if self._ceilometer is None: if self._ceilometer is None:
self._ceilometer = ceil.CeilometerHelper(osc=self.osc) self.ceilometer = ceil.CeilometerHelper(osc=self.osc)
return self._ceilometer return self._ceilometer
@ceilometer.setter @ceilometer.setter
@@ -128,7 +128,7 @@ class VMWorkloadConsolidation(base.ServerConsolidationBaseStrategy):
@property @property
def gnocchi(self): def gnocchi(self):
if self._gnocchi is None: if self._gnocchi is None:
self._gnocchi = gnoc.GnocchiHelper(osc=self.osc) self.gnocchi = gnoc.GnocchiHelper(osc=self.osc)
return self._gnocchi return self._gnocchi
@gnocchi.setter @gnocchi.setter

4
watcher/decision_engine/strategy/strategies/workload_balance.py
View File

@@ -117,7 +117,7 @@ class WorkloadBalance(base.WorkloadStabilizationBaseStrategy):
@property @property
def ceilometer(self): def ceilometer(self):
if self._ceilometer is None: if self._ceilometer is None:
self._ceilometer = ceil.CeilometerHelper(osc=self.osc) self.ceilometer = ceil.CeilometerHelper(osc=self.osc)
return self._ceilometer return self._ceilometer
@ceilometer.setter @ceilometer.setter
@@ -127,7 +127,7 @@ class WorkloadBalance(base.WorkloadStabilizationBaseStrategy):
@property @property
def gnocchi(self): def gnocchi(self):
if self._gnocchi is None: if self._gnocchi is None:
self._gnocchi = gnoc.GnocchiHelper(osc=self.osc) self.gnocchi = gnoc.GnocchiHelper(osc=self.osc)
return self._gnocchi return self._gnocchi
@gnocchi.setter @gnocchi.setter

6
watcher/decision_engine/strategy/strategies/workload_stabilization.py
View File

@@ -179,13 +179,13 @@ class WorkloadStabilization(base.WorkloadStabilizationBaseStrategy):
@property @property
def ceilometer(self): def ceilometer(self):
if self._ceilometer is None: if self._ceilometer is None:
self._ceilometer = ceil.CeilometerHelper(osc=self.osc) self.ceilometer = ceil.CeilometerHelper(osc=self.osc)
return self._ceilometer return self._ceilometer
@property @property
def nova(self): def nova(self):
if self._nova is None: if self._nova is None:
self._nova = self.osc.nova() self.nova = self.osc.nova()
return self._nova return self._nova
@nova.setter @nova.setter
@@ -199,7 +199,7 @@ class WorkloadStabilization(base.WorkloadStabilizationBaseStrategy):
@property @property
def gnocchi(self): def gnocchi(self):
if self._gnocchi is None: if self._gnocchi is None:
self._gnocchi = gnoc.GnocchiHelper(osc=self.osc) self.gnocchi = gnoc.GnocchiHelper(osc=self.osc)
return self._gnocchi return self._gnocchi
@gnocchi.setter @gnocchi.setter