Merge "Rename NovaWrapper to NovaClient"
This commit is contained in:
@@ -24,15 +24,15 @@ import keystoneclient.v3.client as ksclient
|
||||
import mock
|
||||
import novaclient.client as nvclient
|
||||
|
||||
from watcher.applier.primitives.wrapper.nova_wrapper import NovaWrapper
|
||||
from watcher.common.nova import NovaClient
|
||||
from watcher.common import utils
|
||||
from watcher.tests import base
|
||||
|
||||
|
||||
class TestNovaWrapper(base.TestCase):
|
||||
class TestNovaClient(base.TestCase):
|
||||
|
||||
def setUp(self):
|
||||
super(TestNovaWrapper, self).setUp()
|
||||
super(TestNovaClient, self).setUp()
|
||||
self.instance_uuid = "fb5311b7-37f3-457e-9cde-6494a3c59bfe"
|
||||
self.source_hypervisor = "ldev-indeedsrv005"
|
||||
self.destination_hypervisor = "ldev-indeedsrv006"
|
||||
@@ -43,38 +43,38 @@ class TestNovaWrapper(base.TestCase):
|
||||
@mock.patch.object(ksclient, "Client", mock.Mock())
|
||||
@mock.patch.object(nvclient, "Client", mock.Mock())
|
||||
def test_stop_instance(self):
|
||||
wrapper = NovaWrapper(creds=self.creds, session=self.session)
|
||||
nova_client = NovaClient(creds=self.creds, session=self.session)
|
||||
instance_id = utils.generate_uuid()
|
||||
server = mock.MagicMock()
|
||||
server.id = instance_id
|
||||
setattr(server, 'OS-EXT-STS:vm_state', 'stopped')
|
||||
wrapper.nova.servers = mock.MagicMock()
|
||||
wrapper.nova.servers.find.return_value = server
|
||||
wrapper.nova.servers.list.return_value = [server]
|
||||
nova_client.nova.servers = mock.MagicMock()
|
||||
nova_client.nova.servers.find.return_value = server
|
||||
nova_client.nova.servers.list.return_value = [server]
|
||||
|
||||
result = wrapper.stop_instance(instance_id)
|
||||
result = nova_client.stop_instance(instance_id)
|
||||
self.assertEqual(result, True)
|
||||
|
||||
@mock.patch.object(ksclient, "Client", mock.Mock())
|
||||
@mock.patch.object(nvclient, "Client", mock.Mock())
|
||||
def test_set_host_offline(self):
|
||||
wrapper = NovaWrapper(creds=self.creds, session=self.session)
|
||||
nova_client = NovaClient(creds=self.creds, session=self.session)
|
||||
host = mock.MagicMock()
|
||||
wrapper.nova.hosts = mock.MagicMock()
|
||||
wrapper.nova.hosts.get.return_value = host
|
||||
result = wrapper.set_host_offline("rennes")
|
||||
nova_client.nova.hosts = mock.MagicMock()
|
||||
nova_client.nova.hosts.get.return_value = host
|
||||
result = nova_client.set_host_offline("rennes")
|
||||
self.assertEqual(result, True)
|
||||
|
||||
@mock.patch.object(time, 'sleep', mock.Mock())
|
||||
@mock.patch.object(ksclient, "Client", mock.Mock())
|
||||
@mock.patch.object(nvclient, "Client", mock.Mock())
|
||||
def test_live_migrate_instance(self):
|
||||
wrapper = NovaWrapper(creds=self.creds, session=self.session)
|
||||
nova_client = NovaClient(creds=self.creds, session=self.session)
|
||||
server = mock.MagicMock()
|
||||
server.id = self.instance_uuid
|
||||
wrapper.nova.servers = mock.MagicMock()
|
||||
wrapper.nova.servers.list.return_value = [server]
|
||||
instance = wrapper.live_migrate_instance(
|
||||
nova_client.nova.servers = mock.MagicMock()
|
||||
nova_client.nova.servers.list.return_value = [server]
|
||||
instance = nova_client.live_migrate_instance(
|
||||
self.instance_uuid, self.destination_hypervisor
|
||||
)
|
||||
self.assertIsNotNone(instance)
|
||||
@@ -82,11 +82,11 @@ class TestNovaWrapper(base.TestCase):
|
||||
@mock.patch.object(ksclient, "Client", mock.Mock())
|
||||
@mock.patch.object(nvclient, "Client", mock.Mock())
|
||||
def test_watcher_non_live_migrate_instance_not_found(self):
|
||||
wrapper = NovaWrapper(creds=self.creds, session=self.session)
|
||||
wrapper.nova.servers.list.return_value = []
|
||||
wrapper.nova.servers.find.return_value = None
|
||||
nova_client = NovaClient(creds=self.creds, session=self.session)
|
||||
nova_client.nova.servers.list.return_value = []
|
||||
nova_client.nova.servers.find.return_value = None
|
||||
|
||||
is_success = wrapper.watcher_non_live_migrate_instance(
|
||||
is_success = nova_client.watcher_non_live_migrate_instance(
|
||||
self.instance_uuid,
|
||||
self.destination_hypervisor)
|
||||
|
||||
@@ -96,12 +96,12 @@ class TestNovaWrapper(base.TestCase):
|
||||
@mock.patch.object(ksclient, "Client", mock.Mock())
|
||||
@mock.patch.object(nvclient, "Client", mock.Mock())
|
||||
def test_watcher_non_live_migrate_instance_volume(self):
|
||||
wrapper = NovaWrapper(creds=self.creds, session=self.session)
|
||||
nova_client = NovaClient(creds=self.creds, session=self.session)
|
||||
instance = mock.MagicMock(id=self.instance_uuid)
|
||||
setattr(instance, 'OS-EXT-SRV-ATTR:host', self.source_hypervisor)
|
||||
wrapper.nova.servers.list.return_value = [instance]
|
||||
wrapper.nova.servers.find.return_value = instance
|
||||
instance = wrapper.watcher_non_live_migrate_instance(
|
||||
nova_client.nova.servers.list.return_value = [instance]
|
||||
nova_client.nova.servers.find.return_value = instance
|
||||
instance = nova_client.watcher_non_live_migrate_instance(
|
||||
self.instance_uuid,
|
||||
self.destination_hypervisor)
|
||||
self.assertIsNotNone(instance)
|
||||
@@ -110,7 +110,7 @@ class TestNovaWrapper(base.TestCase):
|
||||
@mock.patch.object(ksclient, "Client", mock.Mock())
|
||||
@mock.patch.object(nvclient, "Client", mock.Mock())
|
||||
def test_watcher_non_live_migrate_keep_image(self):
|
||||
wrapper = NovaWrapper(creds=self.creds, session=self.session)
|
||||
nova_client = NovaClient(creds=self.creds, session=self.session)
|
||||
instance = mock.MagicMock(id=self.instance_uuid)
|
||||
setattr(instance, 'OS-EXT-SRV-ATTR:host', self.source_hypervisor)
|
||||
addresses = mock.MagicMock()
|
||||
@@ -122,9 +122,9 @@ class TestNovaWrapper(base.TestCase):
|
||||
setattr(instance, 'addresses', addresses)
|
||||
setattr(instance, "os-extended-volumes:volumes_attached",
|
||||
attached_volumes)
|
||||
wrapper.nova.servers.list.return_value = [instance]
|
||||
wrapper.nova.servers.find.return_value = instance
|
||||
instance = wrapper.watcher_non_live_migrate_instance(
|
||||
nova_client.nova.servers.list.return_value = [instance]
|
||||
nova_client.nova.servers.find.return_value = instance
|
||||
instance = nova_client.watcher_non_live_migrate_instance(
|
||||
self.instance_uuid,
|
||||
self.destination_hypervisor, keep_original_image_name=False)
|
||||
self.assertIsNotNone(instance)
|
||||
@@ -134,20 +134,20 @@ class TestNovaWrapper(base.TestCase):
|
||||
@mock.patch.object(nvclient, "Client", mock.Mock())
|
||||
@mock.patch.object(glclient, "Client")
|
||||
def test_create_image_from_instance(self, m_glance_cls):
|
||||
wrapper = NovaWrapper(creds=self.creds, session=self.session)
|
||||
nova_client = NovaClient(creds=self.creds, session=self.session)
|
||||
instance = mock.MagicMock()
|
||||
image = mock.MagicMock()
|
||||
setattr(instance, 'OS-EXT-SRV-ATTR:host', self.source_hypervisor)
|
||||
wrapper.nova.servers.list.return_value = [instance]
|
||||
wrapper.nova.servers.find.return_value = instance
|
||||
nova_client.nova.servers.list.return_value = [instance]
|
||||
nova_client.nova.servers.find.return_value = instance
|
||||
image_uuid = 'fake-image-uuid'
|
||||
wrapper.nova.servers.create_image.return_value = image
|
||||
nova_client.nova.servers.create_image.return_value = image
|
||||
|
||||
m_glance = mock.MagicMock()
|
||||
m_glance_cls.return_value = m_glance
|
||||
|
||||
m_glance.images = {image_uuid: image}
|
||||
instance = wrapper.create_image_from_instance(
|
||||
instance = nova_client.create_image_from_instance(
|
||||
self.instance_uuid, "Cirros"
|
||||
)
|
||||
self.assertIsNone(instance)
|
||||
Reference in New Issue
Block a user