From c1cbd9ebf4002c3b386d8ef87e57bcec6dc71dda Mon Sep 17 00:00:00 2001 From: Bin Zhou Date: Fri, 2 Sep 2016 12:23:26 +0800 Subject: [PATCH] Modify use of assertTrue(A in B) Developers should use assertIn(A, B) instead of assertTrue(A in B ). TrivialFix Change-Id: Ie169e731c800b5d77fd231f09ac7f92090287ef3 --- .../tests/decision_engine/scoring/test_dummy_scorer.py | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/watcher/tests/decision_engine/scoring/test_dummy_scorer.py b/watcher/tests/decision_engine/scoring/test_dummy_scorer.py index 69ac82488..43a91c729 100644 --- a/watcher/tests/decision_engine/scoring/test_dummy_scorer.py +++ b/watcher/tests/decision_engine/scoring/test_dummy_scorer.py @@ -30,12 +30,12 @@ class TestDummyScorer(base.TestCase): def test_metadata(self): scorer = dummy_scorer.DummyScorer(config=None) self.assertEqual('dummy_scorer', scorer.get_name()) - self.assertTrue('Dummy' in scorer.get_description()) + self.assertIn('Dummy', scorer.get_description()) metainfo = scorer.get_metainfo() - self.assertTrue('feature_columns' in metainfo) - self.assertTrue('result_columns' in metainfo) - self.assertTrue('workloads' in metainfo) + self.assertIn('feature_columns', metainfo) + self.assertIn('result_columns', metainfo) + self.assertIn('workloads', metainfo) def test_calculate_score(self): scorer = dummy_scorer.DummyScorer(config=None)