Arnike/watcher
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fixed wrongly used assertEqual method

Browse Source 
In several places, assertEqual is used the following way:
  assertEqual(observed, expected)
However, the correct way to use assertEqual is:
  assertEqual(expected, observed)

Change-Id: I5a7442f4adf98bf7bc73cef1d17d20da39d9a7f8
Closes-Bug: #1551861
This commit is contained in:
Gábor Antal
2016-03-01 18:14:05 +01:00
parent 1acacaa812
commit c440cdd69f
40 changed files with 163 additions and 167 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
watcher/tests/common/test_ceilometer_helper.py
View File

@@ -44,7 +44,7 @@ class TestCeilometerHelper(base.BaseTestCase):
user_ids=["user_ids"],
tenant_ids=["tenant_ids"],
resource_ids=["resource_ids"])
self.assertEqual(query, expected)
self.assertEqual(expected, query)
def test_statistic_aggregation(self, mock_ceilometer):
cm = ceilometer_helper.CeilometerHelper()
@@ -60,7 +60,7 @@ class TestCeilometerHelper(base.BaseTestCase):
meter_name="cpu_util",
period="7300"
)
self.assertEqual(val, expected_result)
self.assertEqual(expected_result, val)
def test_get_last_sample(self, mock_ceilometer):
ceilometer = mock.MagicMock()
@@ -74,7 +74,7 @@ class TestCeilometerHelper(base.BaseTestCase):
resource_id="id",
meter_name="compute.node.percent"
)
self.assertEqual(val, expected_result)
self.assertEqual(expected_result, val)
def test_get_last_sample_none(self, mock_ceilometer):
ceilometer = mock.MagicMock()
@@ -86,7 +86,7 @@ class TestCeilometerHelper(base.BaseTestCase):
resource_id="id",
meter_name="compute.node.percent"
)
self.assertEqual(val, expected)
self.assertEqual(expected, val)
def test_statistic_list(self, mock_ceilometer):
ceilometer = mock.MagicMock()
@@ -95,4 +95,4 @@ class TestCeilometerHelper(base.BaseTestCase):
mock_ceilometer.return_value = ceilometer
cm = ceilometer_helper.CeilometerHelper()
val = cm.statistic_list(meter_name="cpu_util")
self.assertEqual(val, expected_value)
self.assertEqual(expected_value, val)