Arnike/watcher
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Added unit tests on nova wrapper

Browse Source 
As the coverage on the nova wrapper is actually very low, this
patchset is here to raise it a bit since it is a quite central
piece of code.

Change-Id: Ie7879c74c8d322d5031953827c339bb11d9085c1
This commit is contained in:
Vincent Françoise
2015-12-08 15:19:35 +01:00
parent b1fe7a5f3d
commit d92f85574d
1 changed files with 105 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files

123
watcher/tests/applier/actions/wrapper/test_nova_wrapper.py
View File

@@ -16,16 +16,22 @@
# See the License for the specific language governing permissions and # See the License for the specific language governing permissions and
# limitations under the License. # limitations under the License.
# #
import mock
import time import time
import glanceclient.v2.client as glclient
import keystoneclient.v3.client as ksclient
import mock
import novaclient.client as nvclient
from watcher.applier.primitives.wrapper.nova_wrapper import NovaWrapper from watcher.applier.primitives.wrapper.nova_wrapper import NovaWrapper
from watcher.common import utils from watcher.common import utils
from watcher.tests import base from watcher.tests import base
class TestNovaWrapper(base.TestCase): class TestNovaWrapper(base.TestCase):
@mock.patch('keystoneclient.v3.client.Client')
def setUp(self, mock_ksclient): def setUp(self):
super(TestNovaWrapper, self).setUp() super(TestNovaWrapper, self).setUp()
self.instance_uuid = "fb5311b7-37f3-457e-9cde-6494a3c59bfe" self.instance_uuid = "fb5311b7-37f3-457e-9cde-6494a3c59bfe"
self.source_hypervisor = "ldev-indeedsrv005" self.source_hypervisor = "ldev-indeedsrv005"
@@ -33,34 +39,115 @@ class TestNovaWrapper(base.TestCase):
self.creds = mock.MagicMock() self.creds = mock.MagicMock()
self.session = mock.MagicMock() self.session = mock.MagicMock()
self.wrapper = NovaWrapper(creds=self.creds, session=self.session)
@mock.patch.object(ksclient, "Client", mock.Mock())
@mock.patch.object(nvclient, "Client", mock.Mock())
def test_stop_instance(self): def test_stop_instance(self):
wrapper = NovaWrapper(creds=self.creds, session=self.session)
instance_id = utils.generate_uuid() instance_id = utils.generate_uuid()
server = mock.MagicMock() server = mock.MagicMock()
server.id = instance_id server.id = instance_id
setattr(server, 'OS-EXT-STS:vm_state', 'stopped') setattr(server, 'OS-EXT-STS:vm_state', 'stopped')
self.wrapper.nova.servers = mock.MagicMock() wrapper.nova.servers = mock.MagicMock()
self.wrapper.nova.servers.find.return_value = server wrapper.nova.servers.find.return_value = server
self.wrapper.nova.servers.list.return_value = [server] wrapper.nova.servers.list.return_value = [server]
result = self.wrapper.stop_instance(instance_id) result = wrapper.stop_instance(instance_id)
self.assertEqual(result, True) self.assertEqual(result, True)
@mock.patch.object(ksclient, "Client", mock.Mock())
@mock.patch.object(nvclient, "Client", mock.Mock())
def test_set_host_offline(self): def test_set_host_offline(self):
wrapper = NovaWrapper(creds=self.creds, session=self.session)
host = mock.MagicMock() host = mock.MagicMock()
self.wrapper.nova.hosts = mock.MagicMock() wrapper.nova.hosts = mock.MagicMock()
self.wrapper.nova.hosts.get.return_value = host wrapper.nova.hosts.get.return_value = host
result = self.wrapper.set_host_offline("rennes") result = wrapper.set_host_offline("rennes")
self.assertEqual(result, True) self.assertEqual(result, True)
@mock.patch.object(time, 'sleep', mock.Mock())
@mock.patch.object(ksclient, "Client", mock.Mock())
@mock.patch.object(nvclient, "Client", mock.Mock())
def test_live_migrate_instance(self): def test_live_migrate_instance(self):
wrapper = NovaWrapper(creds=self.creds, session=self.session)
server = mock.MagicMock() server = mock.MagicMock()
server.id = self.instance_uuid server.id = self.instance_uuid
self.wrapper.nova.servers = mock.MagicMock() wrapper.nova.servers = mock.MagicMock()
self.wrapper.nova.servers.list.return_value = [server] wrapper.nova.servers.list.return_value = [server]
with mock.patch.object(time, 'sleep'): instance = wrapper.live_migrate_instance(
instance = self.wrapper.live_migrate_instance( self.instance_uuid, self.destination_hypervisor
self.instance_uuid, )
self.destination_hypervisor) self.assertIsNotNone(instance)
self.assertIsNotNone(instance)
@mock.patch.object(ksclient, "Client", mock.Mock())
@mock.patch.object(nvclient, "Client", mock.Mock())
def test_watcher_non_live_migrate_instance_not_found(self):
wrapper = NovaWrapper(creds=self.creds, session=self.session)
wrapper.nova.servers.list.return_value = []
wrapper.nova.servers.find.return_value = None
is_success = wrapper.watcher_non_live_migrate_instance(
self.instance_uuid,
self.destination_hypervisor)
self.assertEqual(is_success, False)
@mock.patch.object(time, 'sleep', mock.Mock())
@mock.patch.object(ksclient, "Client", mock.Mock())
@mock.patch.object(nvclient, "Client", mock.Mock())
def test_watcher_non_live_migrate_instance_volume(self):
wrapper = NovaWrapper(creds=self.creds, session=self.session)
instance = mock.MagicMock(id=self.instance_uuid)
setattr(instance, 'OS-EXT-SRV-ATTR:host', self.source_hypervisor)
wrapper.nova.servers.list.return_value = [instance]
wrapper.nova.servers.find.return_value = instance
instance = wrapper.watcher_non_live_migrate_instance(
self.instance_uuid,
self.destination_hypervisor)
self.assertIsNotNone(instance)
@mock.patch.object(time, 'sleep', mock.Mock())
@mock.patch.object(ksclient, "Client", mock.Mock())
@mock.patch.object(nvclient, "Client", mock.Mock())
def test_watcher_non_live_migrate_keep_image(self):
wrapper = NovaWrapper(creds=self.creds, session=self.session)
instance = mock.MagicMock(id=self.instance_uuid)
setattr(instance, 'OS-EXT-SRV-ATTR:host', self.source_hypervisor)
addresses = mock.MagicMock()
type = mock.MagicMock()
networks = []
networks.append(("lan", type))
addresses.items.return_value = networks
attached_volumes = mock.MagicMock()
setattr(instance, 'addresses', addresses)
setattr(instance, "os-extended-volumes:volumes_attached",
attached_volumes)
wrapper.nova.servers.list.return_value = [instance]
wrapper.nova.servers.find.return_value = instance
instance = wrapper.watcher_non_live_migrate_instance(
self.instance_uuid,
self.destination_hypervisor, keep_original_image_name=False)
self.assertIsNotNone(instance)
@mock.patch.object(time, 'sleep', mock.Mock())
@mock.patch.object(ksclient, "Client", mock.Mock())
@mock.patch.object(nvclient, "Client", mock.Mock())
@mock.patch.object(glclient, "Client")
def test_create_image_from_instance(self, m_glance_cls):
wrapper = NovaWrapper(creds=self.creds, session=self.session)
instance = mock.MagicMock()
image = mock.MagicMock()
setattr(instance, 'OS-EXT-SRV-ATTR:host', self.source_hypervisor)
wrapper.nova.servers.list.return_value = [instance]
wrapper.nova.servers.find.return_value = instance
image_uuid = 'fake-image-uuid'
wrapper.nova.servers.create_image.return_value = image
m_glance = mock.MagicMock()
m_glance_cls.return_value = m_glance
m_glance.images = {image_uuid: image}
instance = wrapper.create_image_from_instance(
self.instance_uuid, "Cirros"
)
self.assertIsNone(instance)