Arnike/watcher
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Rename (pre/post)condition to (pre/post)_condition

Browse Source 
This patch updates the applier's abstract methods to be consistent
with other abstract methods of similar nature.

Also included are a few other miscellaneous changes.

Change-Id: Ia1527c00332011412aba2ab326ec986f1e773001
Closes-bug: 1606634
This commit is contained in:
Joe Cropper
2016-08-06 16:21:30 -05:00
parent 27b3c5254d
commit ea01031268
11 changed files with 65 additions and 65 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
watcher/applier/workflow_engine/default.py
View File

@@ -109,8 +109,8 @@ class TaskFlowActionContainer(task.Task):
try:
self.engine.notify(self._db_action,
obj_action.State.ONGOING)
LOG.debug("Precondition action %s", self.name)
self.action.precondition()
LOG.debug("Pre-condition action: %s", self.name)
self.action.pre_condition()
except Exception as e:
LOG.exception(e)
self.engine.notify(self._db_action,
@@ -119,15 +119,15 @@ class TaskFlowActionContainer(task.Task):
def execute(self, *args, **kwargs):
try:
LOG.debug("Running action %s", self.name)
LOG.debug("Running action: %s", self.name)
self.action.execute()
self.engine.notify(self._db_action,
obj_action.State.SUCCEEDED)
except Exception as e:
LOG.exception(e)
LOG.error(_LE('The WorkFlow Engine has failed '
'to execute the action %s'), self.name)
LOG.error(_LE('The workflow engine has failed '
'to execute the action: %s'), self.name)
self.engine.notify(self._db_action,
obj_action.State.FAILED)
@@ -135,8 +135,8 @@ class TaskFlowActionContainer(task.Task):
def post_execute(self):
try:
LOG.debug("postcondition action %s", self.name)
self.action.postcondition()
LOG.debug("Post-condition action: %s", self.name)
self.action.post_condition()
except Exception as e:
LOG.exception(e)
self.engine.notify(self._db_action,
@@ -144,19 +144,19 @@ class TaskFlowActionContainer(task.Task):
raise
def revert(self, *args, **kwargs):
LOG.warning(_LW("Revert action %s"), self.name)
LOG.warning(_LW("Revert action: %s"), self.name)
try:
# todo(jed) do we need to update the states in case of failure ?
# TODO(jed): do we need to update the states in case of failure?
self.action.revert()
except Exception as e:
LOG.exception(e)
LOG.critical(_LC("Oops! We need disaster recover plan"))
LOG.critical(_LC("Oops! We need a disaster recover plan."))
class TaskFlowNop(task.Task):
"""This class is use in case of the workflow have only one Action.
"""This class is used in case of the workflow have only one Action.
We need at least two atoms to create a link
We need at least two atoms to create a link.
"""
def execute(self):
pass