Commit Graph

1498 Commits

Author SHA1 Message Date
Jean-Emile DARTOIS
109a980c29 Rename command to action_plan
Some Python class and packages need to be renamed
for a better compliance with the shared terminology
which provides a better understanding of Watcher
objects and components by every contributor.

This patchset is there to change command to action_plan

Partially implements: blueprint glossary-related-refactoring

Change-Id: I19a70adeca347ce747a2221b5fc31658139c95a2
2015-12-08 15:26:44 +01:00
Vincent Françoise
531373cb84 Removed unused enum
This StrategyState Enum is not used anywhere in the codebase (and
shouldn't be), so I removed it.

Change-Id: I0b5d3102b4d08856dccd751313fdd097937d8ccf
2015-12-08 14:22:22 +01:00
Jean-Emile DARTOIS
087c4d49ed Rename Meta-Action to Action
Some Python class and packages need to be renamed
for a better compliance with the shared terminology
which provides a better understanding of Watcher
objects and components by every contributor.

This patchset is there to change Meta-Action to Action

Partially implements: blueprint glossary-related-refactoring

Change-Id: Ie67b800332179be93718030ddd7a36ddc76a544c
2015-12-08 11:53:29 +01:00
Jean-Emile DARTOIS
022b15dc1e Add a checker for the documentation
This patchset add some unit tests on the documentation:
Checking wrapping
Checking trailing spaces
Checking no_cr

Change-Id: I3fa56d3e7dd3218dcd398e6750bdd2fb3a8e75b4
2015-12-08 11:28:45 +01:00
Jean-Emile DARTOIS
454f70a19f Rename efficiency to efficacy
Some Python class and packages need to be renamed
for a better compliance with the shared Terminology
which provides a better understanding of Watcher
objects and components by every contributor.

This patchset is there to change efficiency to efficacy

Partially implements: blueprint glossary-related-refactoring

Change-Id: I4c84192d49a147e0fd406da35e2805143b902331
2015-12-08 09:18:48 +00:00
Steve Wilkerson
98f05a52a8 Fix Watcher Applier variables in CamelCase
PEP8 standards call for instance variable names to be written
in the same manner as methods, with underscores separating words.
This fix addresses an instance variable  in the DeployPhase class.

As the instance variable seems public, the Java-ish getter and
setter mentioned in the bug report have been removed as well.

Change-Id: I8835315c8cae64665d3ccb321c4066e37a22c467
Closes-Bug: 1522489
2015-12-07 10:40:57 -06:00
Jenkins
5ff9f28a83 Merge "Remove duplicate setup in Watcher API main()" 2015-12-07 10:35:55 +00:00
Darren Shaw
4a88220ffe Remove duplicate setup in Watcher API main()
main() duplicates code for oslo_log setup, which is first
called within prepare_services(). This patches removes
the duplication call in main()

Change-Id: I712d3733218c18b2eb02d4bf26e54b29ef72a988
Closes-Bug: #1522781
2015-12-04 20:39:42 -06:00
Jean-Emile DARTOIS
4c2d0e6345 Cleanup deprecated documentation
Since vincent mahe created a great
documentation available in doc/source
this one is deprecated

Change-Id: I81ff633771570f28a38e3d277718f0a97a9d5090
2015-12-04 18:21:47 +01:00
Jean-Emile DARTOIS
da4c9125f7 Fixed missing attribute in the data model
Querying compute.node.* with Ceilometer requires some additional
information in the cluster data model in order to build the
resource_id. This patchset add the attribute hostname and change
the query.

Change-Id: Ifcefcd70a6d0f5967ab4f638ce077e38ef214f64
Closes-Bug: #1521559
2015-12-04 12:14:25 +01:00
Jenkins
ee82531314 Merge "Code refactoring - Watcher Applier package" 2015-12-03 14:54:49 +00:00
Jenkins
2a06c2b7cc Merge "Fixed doc generation warning" 2015-12-03 13:28:38 +00:00
Vincent Françoise
289c79e52f Code refactoring - Watcher Applier package
This patchset is there to change the code structure.
The objective is to flatten the project file tree by merging
'api/' and 'framework/' into a single package. This also contains
some tidy ups in package naming (like using only singular nouns).

This should only affect file/folder names and their subsequent
import paths wherever they were used.

Change-Id: Id7b37667c613086d8ef3cd1f367c4219bf026fc7
2015-12-03 12:08:18 +01:00
Jenkins
6d17426675 Merge "Fixed tense consistency (used past) in statuses" 2015-12-03 11:06:37 +00:00
Vincent Françoise
c178b79f57 Removed old (and unused) openstack/oslo libs
Since all oslo libs are now using the new versions installed using
pip, there is no need to keep the watcher/openstack/common/ folder.

Implements: blueprint make-watcher-use-graduated-oslo-lib
Change-Id: I9e08b4a50c6b15a4d51a7f53fdd615d6c28fdce7
2015-12-02 17:48:07 +01:00
Vincent Françoise
f555e66d75 Fixed doc generation warning
The BaseStrategy interface was moved to another location but the
documentation wasn't updated accordingly, so here I updated this
import path.
As an extra, I also updated the description of the Solution which
also had an outdated import path.

Closes-Bug: #1522034
Change-Id: I8cd43e84db6945391db06ec6dfe82ce02eccc7f4
2015-12-02 16:55:12 +01:00
Jenkins
8018f74a81 Merge "Removed 'watcher_messaging' to use oslo.messaging" 2015-12-02 11:16:53 +00:00
Jenkins
2737791a58 Merge "Added priority level to Nop action" 2015-12-02 10:25:08 +00:00
Vincent Françoise
1cf4e15276 Added priority level to Nop action
Change-Id: I166e9cc80b1d9e326c9d65b47e38da26dffb5004
Closes-Bug: #1521898
2015-12-02 11:04:07 +01:00
Jenkins
6ffdbf6b91 Merge "Improve OpenStack clients API" 2015-12-01 16:32:04 +00:00
Vincent Françoise
8756c70060 Removed 'watcher_messaging' to use oslo.messaging
The old 'watcher_messaging' section of the Watcher configuration file
has now been replaced by the more standard oslo.configuration one.

DocImpact

Change-Id: Ie027df023e6133f3188e57b42846083f28c282bd
2015-12-01 16:02:03 +01:00
Jean-Emile DARTOIS
1300309264 Improve OpenStack clients API
Change-Id: I53137dcbd38dc7846acbad4364e02a9fb77a4c19
2015-12-01 16:00:47 +01:00
Jenkins
44cfa11b0e Merge "Added 'dummy' entrypoint within watcher_strategies" 2015-12-01 11:15:09 +00:00
Vincent Françoise
9078e1e138 Added 'dummy' entrypoint within watcher_strategies
This should make our 'dummy' strategy available for use.
I also removed all previously defined default goals, which means
that they will have to define it themselves from now on.
This can also be useful for future integration tests.

Change-Id: I6c43eba941022a88851a199b56a6c20f017b9e71
DocImpact
Closes-Bug: #1520178
2015-11-30 16:06:45 +01:00
Gábor Antal
6e1e445e55 Fixed tense consistency (used past) in statuses
In several places in Watcher, there are statuses which corresponds
to a status in the respective life cycle. There were used past tense
everywhere, except "SUCCESS" which was written in present tense.

So I searched for all the occurences of this state, and replaced them
with their past tense form.

Change-Id: Ic41def96d1a608da06a1e394e24704d4f06ab32a
Closes-Bug: #1520276
2015-11-27 19:10:00 +01:00
Gábor Antal
193c1924cc Added LaunchActionPlanCommand's init super call
Added the missing super() call in the LaunchActionPlanCommand class
__init__() method, as it was requested.

Change-Id: I6d8cc7880b1e979f94acd3fdd84e3f6d1a90a032
Closes-Bug: #1520521
2015-11-27 17:46:27 +01:00
Jenkins
a809b8d52c Merge "Added missing super call in DefaultApplier's init" 2015-11-27 16:36:11 +00:00
Gábor Antal
4ee06a4417 Added missing super call in DefaultApplier's init
Added the missing super() call in the DefaultApplier class
__init__() method, as it was requested.

Change-Id: I58be9671e9635d800d63480043e2e4cd752d45fd
Closes-Bug: #1520524
2015-11-27 17:25:02 +01:00
Jenkins
9d153e13a3 Merge "AMQP Channel have to be set espacially to 'watcher'" 2015-11-27 15:42:12 +00:00
David TARDIVEL
aa1b1da759 AMQP Channel have to be set espacially to 'watcher'
Default channel used is named 'openstack'. But Watcher AMQP topics are
bound to 'watcher' channel. So, on RCPClient init, we have to set
the channel name to 'watcher' for the target.

Change-Id: Ifdbb187f1ee60f898ef0340e0c037891350ce815
Closes-Bug: #1520599
2015-11-27 16:13:03 +01:00
Vincent Françoise
5f8a601c63 Updated the config sample file generation command
Following the update of the project requirements, we should now
use the oslo.config namespace of oslo.log when generating ou
Watcher config sample file.

Change-Id: I7a1f3d555534b40c041b7f042f19fae231b7e80c
Closes-Bug: #1518297
2015-11-27 15:46:49 +01:00
Vincent Françoise
eb3870a4b3 Code refactoring - Watcher Decision Engine package
This patchset is there to change the code structure.
The objective is to flatten the project file tree by merging
'api/' and 'framework/' into a single package. This also contains
some tidy ups in package naming (like using only singular nouns).

This should only affect file/folder names and their subsequent
import paths wherever they were used.

Change-Id: Ie903ba20ca5cf03b0b42efa60131d1b919b0c2c9
2015-11-26 12:06:28 +01:00
Jenkins
6e81a31bd8 Merge "Update requirements from OS Global Requirements." 2015-11-25 14:58:59 +00:00
Vincent Françoise
3a03eb930c Strategy plugins documentation
Following https://review.openstack.org/#/c/245903, this patchset
documents the implementation and integration of custom Strategies
with Watcher.

Change-Id: I573758695d67d523834f145824b6f6cfdd8997fe
2015-11-24 18:02:06 +01:00
David TARDIVEL
7c8acebcb2 Update requirements from OS Global Requirements.
Update requirements.txt and test-requirements.txt from Global Requirements
defined into openstack/requirements project (stable/liberty).

Change-Id: I9ecbf5a7fb2c38624cc4f52b13515f8af75a4889
Closes-Bug: #1513118
2015-11-24 15:56:53 +01:00
Vincent Françoise
f8a80938ef Made Decision Engine extensible via stevedore
The objective for this is to give the ability to extend the default
set of placement algorithms (i.e. strategies) currently available
in Watcher using Stevedore.

Now, you can add your new strategy as an entry point under the
'[watcher_strategies]' section.

Change-Id: I4aecf629015e41b0389d07e47220333e50bbbe1a
2015-11-23 17:38:03 +01:00
Jean-Emile DARTOIS
827563608f Integration of Ceilometer in Watcher
In current implementation is not easy to use ceilometer.
Watcher must query metrics from the Telemetry v2 API to allow an easiest integration with OpenStack components (especially devstack).

blueprint telemetry-integration
Change-Id: Ide515472f1d160925d9f4aabf48c96dea4f6bc05
2015-11-23 15:29:28 +01:00
Jean-Emile DARTOIS
6a55914b05 Fix config loading when running the watcher-api
This regression was caused when we upgrade the version of olso.
Unfortunately this issue wasn't picked up with the unit tests as
the cmds doesn't have unit tests yet.

Error message: "watcher-api fail with NoSuchOptError: no such option:debug"

This patchset implements unit tests for:

- 'watcher-api' command
- 'watcher-db-manage' command (and sub-command)
- 'watcher-applier' command

Change-Id: I2bea8aee28dec913ebc45f2824bf474f86652642
2015-11-23 10:49:21 +01:00
Jenkins
4d2d73aa98 Merge "Avoid dividing zero" 2015-11-19 09:01:27 +00:00
Zhenzan Zhou
a6db530c77 Avoid dividing zero
Some flavors may set disk size 0 byte, so disk_capacity may be 0.

Change-Id: I0f2cfd5ce9f64cd94e7b6ded7865384cb2b1e190
Closes-Bug: #1517033
2015-11-17 22:04:32 +08:00
Kevin_Zheng
8920fe0649 Should use watcher/common/context.py for consistency
Use watcher/common/context.py in watcher/common/service.py
for consistency

Change-Id: I0dc99e04a3e936c3da38598bd9aac469d79a793b
2015-11-17 14:32:04 +08:00
Kevin_Zheng
f7ac53c04c Update policy.py
Update watcher/openstack/common/policy.py to keep
up with other openstack components.

Change-Id: Ia6cd00363e0fbf0c72a24b3bb9bb5468e17a71e9
2015-11-17 11:32:33 +08:00
David TARDIVEL
c7e5dc5dcd Watcher notification listener is associated with an executor which integrates
the listener with a specific I/O handling framework. blocking executor should be
the default one.

Change-Id: I10431fefa5f9d4dff3f8482a38c534f1263e67e8
2015-11-14 19:23:35 +01:00
wangxiyuan
57be02dcd2 Use i18n directly
We should use i18n directly rather than openstack/common.

Change-Id: I64d3abce4ee2747b670bc921ffbb03d76defd42c
2015-11-13 16:55:34 +08:00
unknown
0c348313a4 Use olso.log directly
As the openstack/common is deprecated, Watcher should use oslo lib
directly to run in the openstack env. So there is much work to do
with oslo. This patch fixed the log part.

Change-Id: I3145a842fe3a22b3d08fec60d180329073edd50f
2015-11-12 16:06:11 +08:00
Jean-Emile DARTOIS
74160c5e78 consolidation of watcher
Change-Id: I9c82ef4d8a81af98afdfc34f5ad496bcade4af6a
2015-10-22 17:04:14 +02:00
Jean-Emile DARTOIS
77fcefbfbb fix dependencies version
Change-Id: I5fc4b3e8193232379a6aa2b6cc4ef6457f0a6ef1
2015-10-22 16:34:14 +02:00
David TARDIVEL
d14e057da1 initial version
Change-Id: I699e0ab082657880998d8618fe29eb7f56c6c661
2015-06-04 15:27:57 +02:00