5f79ab87c7
This chanage enabled codespell in precommit and fixes the existing typos. A followup commit will enable this in tox and ci. Change-Id: I0a11bcd5a88247a48d3437525fc8a3cb3cdd4e58
861 lines
38 KiB
Python
861 lines
38 KiB
Python
# Licensed under the Apache License, Version 2.0 (the "License");
|
|
# you may not use this file except in compliance with the License.
|
|
# You may obtain a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
# distributed under the License is distributed on an "AS IS" BASIS,
|
|
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
# See the License for the specific language governing permissions and
|
|
# limitations under the License.
|
|
|
|
import datetime
|
|
import itertools
|
|
from unittest import mock
|
|
from urllib import parse as urlparse
|
|
|
|
from http import HTTPStatus
|
|
from oslo_config import cfg
|
|
from oslo_serialization import jsonutils
|
|
from oslo_utils import timeutils
|
|
import webtest.app as webtest_app
|
|
from wsme import types as wtypes
|
|
|
|
from watcher.api.controllers.v1 import audit_template as api_audit_template
|
|
from watcher.common import exception
|
|
from watcher.common import utils
|
|
from watcher import objects
|
|
from watcher.tests.api import base as api_base
|
|
from watcher.tests.api import utils as api_utils
|
|
from watcher.tests import base
|
|
from watcher.tests.db import utils as db_utils
|
|
from watcher.tests.objects import utils as obj_utils
|
|
|
|
|
|
def post_get_test_audit_template(**kw):
|
|
goal = db_utils.get_test_goal()
|
|
strategy = db_utils.get_test_strategy(goal_id=goal['id'])
|
|
kw['goal'] = kw.get('goal', goal['uuid'])
|
|
kw['strategy'] = kw.get('strategy', strategy['uuid'])
|
|
kw['scope'] = kw.get('scope', [])
|
|
audit_template = api_utils.audit_template_post_data(**kw)
|
|
return audit_template
|
|
|
|
|
|
class TestAuditTemplateObject(base.TestCase):
|
|
|
|
def test_audit_template_init(self):
|
|
audit_template_dict = post_get_test_audit_template()
|
|
del audit_template_dict['name']
|
|
audit_template = api_audit_template.AuditTemplate(
|
|
**audit_template_dict)
|
|
self.assertEqual(wtypes.Unset, audit_template.name)
|
|
|
|
|
|
class FunctionalTestWithSetup(api_base.FunctionalTest):
|
|
|
|
def setUp(self):
|
|
super(FunctionalTestWithSetup, self).setUp()
|
|
self.fake_goal1 = obj_utils.create_test_goal(
|
|
self.context, id=1, uuid=utils.generate_uuid(), name="dummy_1")
|
|
self.fake_goal2 = obj_utils.create_test_goal(
|
|
self.context, id=2, uuid=utils.generate_uuid(), name="dummy_2")
|
|
self.fake_strategy1 = obj_utils.create_test_strategy(
|
|
self.context, id=1, uuid=utils.generate_uuid(), name="strategy_1",
|
|
goal_id=self.fake_goal1.id)
|
|
self.fake_strategy2 = obj_utils.create_test_strategy(
|
|
self.context, id=2, uuid=utils.generate_uuid(), name="strategy_2",
|
|
goal_id=self.fake_goal2.id)
|
|
|
|
|
|
class TestListAuditTemplate(FunctionalTestWithSetup):
|
|
|
|
def test_empty(self):
|
|
response = self.get_json('/audit_templates')
|
|
self.assertEqual([], response['audit_templates'])
|
|
|
|
def _assert_audit_template_fields(self, audit_template):
|
|
audit_template_fields = ['name', 'goal_uuid', 'goal_name',
|
|
'strategy_uuid', 'strategy_name']
|
|
for field in audit_template_fields:
|
|
self.assertIn(field, audit_template)
|
|
|
|
def test_one(self):
|
|
audit_template = obj_utils.create_test_audit_template(
|
|
self.context, strategy_id=self.fake_strategy1.id)
|
|
response = self.get_json('/audit_templates')
|
|
self.assertEqual(audit_template.uuid,
|
|
response['audit_templates'][0]["uuid"])
|
|
self._assert_audit_template_fields(response['audit_templates'][0])
|
|
|
|
def test_get_one_soft_deleted_ok(self):
|
|
audit_template = obj_utils.create_test_audit_template(self.context)
|
|
audit_template.soft_delete()
|
|
response = self.get_json('/audit_templates',
|
|
headers={'X-Show-Deleted': 'True'})
|
|
self.assertEqual(audit_template.uuid,
|
|
response['audit_templates'][0]["uuid"])
|
|
self._assert_audit_template_fields(response['audit_templates'][0])
|
|
|
|
response = self.get_json('/audit_templates')
|
|
self.assertEqual([], response['audit_templates'])
|
|
|
|
def test_get_one_by_uuid(self):
|
|
audit_template = obj_utils.create_test_audit_template(self.context)
|
|
response = self.get_json(
|
|
'/audit_templates/%s' % audit_template['uuid'])
|
|
self.assertEqual(audit_template.uuid, response['uuid'])
|
|
self._assert_audit_template_fields(response)
|
|
|
|
def test_get_one_by_name(self):
|
|
audit_template = obj_utils.create_test_audit_template(self.context)
|
|
response = self.get_json(urlparse.quote(
|
|
'/audit_templates/%s' % audit_template['name']))
|
|
self.assertEqual(audit_template.uuid, response['uuid'])
|
|
self._assert_audit_template_fields(response)
|
|
|
|
def test_get_one_soft_deleted(self):
|
|
audit_template = obj_utils.create_test_audit_template(self.context)
|
|
audit_template.soft_delete()
|
|
response = self.get_json(
|
|
'/audit_templates/%s' % audit_template['uuid'],
|
|
headers={'X-Show-Deleted': 'True'})
|
|
self.assertEqual(audit_template.uuid, response['uuid'])
|
|
self._assert_audit_template_fields(response)
|
|
|
|
response = self.get_json(
|
|
'/audit_templates/%s' % audit_template['uuid'],
|
|
expect_errors=True)
|
|
self.assertEqual(HTTPStatus.NOT_FOUND, response.status_int)
|
|
|
|
def test_detail(self):
|
|
audit_template = obj_utils.create_test_audit_template(self.context)
|
|
response = self.get_json('/audit_templates/detail')
|
|
self.assertEqual(audit_template.uuid,
|
|
response['audit_templates'][0]["uuid"])
|
|
self._assert_audit_template_fields(response['audit_templates'][0])
|
|
|
|
def test_detail_soft_deleted(self):
|
|
audit_template = obj_utils.create_test_audit_template(self.context)
|
|
audit_template.soft_delete()
|
|
response = self.get_json('/audit_templates/detail',
|
|
headers={'X-Show-Deleted': 'True'})
|
|
self.assertEqual(audit_template.uuid,
|
|
response['audit_templates'][0]["uuid"])
|
|
self._assert_audit_template_fields(response['audit_templates'][0])
|
|
|
|
response = self.get_json('/audit_templates/detail')
|
|
self.assertEqual([], response['audit_templates'])
|
|
|
|
def test_detail_against_single(self):
|
|
audit_template = obj_utils.create_test_audit_template(self.context)
|
|
response = self.get_json(
|
|
'/audit_templates/%s/detail' % audit_template['uuid'],
|
|
expect_errors=True)
|
|
self.assertEqual(HTTPStatus.NOT_FOUND, response.status_int)
|
|
|
|
def test_many(self):
|
|
audit_template_list = []
|
|
for id_ in range(1, 6):
|
|
audit_template = obj_utils.create_test_audit_template(
|
|
self.context, id=id_,
|
|
uuid=utils.generate_uuid(),
|
|
name='My Audit Template {0}'.format(id_))
|
|
audit_template_list.append(audit_template)
|
|
|
|
response = self.get_json('/audit_templates')
|
|
self.assertEqual(len(audit_template_list),
|
|
len(response['audit_templates']))
|
|
uuids = [s['uuid'] for s in response['audit_templates']]
|
|
self.assertEqual(
|
|
sorted([at.uuid for at in audit_template_list]),
|
|
sorted(uuids))
|
|
|
|
def test_many_without_soft_deleted(self):
|
|
audit_template_list = []
|
|
for id_ in range(1, 6):
|
|
audit_template = obj_utils.create_test_audit_template(
|
|
self.context, id=id_, uuid=utils.generate_uuid(),
|
|
name='My Audit Template {0}'.format(id_))
|
|
audit_template_list.append(audit_template)
|
|
|
|
# We soft delete the ones with ID 4 and 5
|
|
[at.soft_delete() for at in audit_template_list[3:]]
|
|
|
|
response = self.get_json('/audit_templates')
|
|
self.assertEqual(3, len(response['audit_templates']))
|
|
uuids = [s['uuid'] for s in response['audit_templates']]
|
|
self.assertEqual(
|
|
sorted([at.uuid for at in audit_template_list[:3]]),
|
|
sorted(uuids))
|
|
|
|
def test_many_with_soft_deleted(self):
|
|
audit_template_list = []
|
|
for id_ in range(1, 6):
|
|
audit_template = obj_utils.create_test_audit_template(
|
|
self.context, id=id_, uuid=utils.generate_uuid(),
|
|
name='My Audit Template {0}'.format(id_))
|
|
audit_template_list.append(audit_template)
|
|
|
|
# We soft delete the ones with ID 4 and 5
|
|
[at.soft_delete() for at in audit_template_list[3:]]
|
|
|
|
response = self.get_json('/audit_templates',
|
|
headers={'X-Show-Deleted': 'True'})
|
|
self.assertEqual(5, len(response['audit_templates']))
|
|
uuids = [s['uuid'] for s in response['audit_templates']]
|
|
self.assertEqual(
|
|
sorted([at.uuid for at in audit_template_list]),
|
|
sorted(uuids))
|
|
|
|
def test_links(self):
|
|
uuid = utils.generate_uuid()
|
|
obj_utils.create_test_audit_template(self.context, id=1, uuid=uuid)
|
|
response = self.get_json('/audit_templates/%s' % uuid)
|
|
self.assertIn('links', response.keys())
|
|
self.assertEqual(2, len(response['links']))
|
|
self.assertIn(uuid, response['links'][0]['href'])
|
|
for link in response['links']:
|
|
bookmark = link['rel'] == 'bookmark'
|
|
self.assertTrue(
|
|
self.validate_link(link['href'], bookmark=bookmark))
|
|
|
|
def test_collection_links(self):
|
|
for id_ in range(5):
|
|
obj_utils.create_test_audit_template(
|
|
self.context, id=id_, uuid=utils.generate_uuid(),
|
|
name='My Audit Template {0}'.format(id_))
|
|
response = self.get_json('/audit_templates/?limit=3')
|
|
self.assertEqual(3, len(response['audit_templates']))
|
|
|
|
next_marker = response['audit_templates'][-1]['uuid']
|
|
self.assertIn(next_marker, response['next'])
|
|
|
|
def test_collection_links_default_limit(self):
|
|
cfg.CONF.set_override('max_limit', 3, 'api')
|
|
for id_ in range(5):
|
|
obj_utils.create_test_audit_template(
|
|
self.context, id=id_, uuid=utils.generate_uuid(),
|
|
name='My Audit Template {0}'.format(id_))
|
|
response = self.get_json('/audit_templates')
|
|
self.assertEqual(3, len(response['audit_templates']))
|
|
|
|
next_marker = response['audit_templates'][-1]['uuid']
|
|
self.assertIn(next_marker, response['next'])
|
|
|
|
def test_filter_by_goal_uuid(self):
|
|
for id_, goal_id in enumerate(itertools.chain.from_iterable([
|
|
itertools.repeat(self.fake_goal1.id, 3),
|
|
itertools.repeat(self.fake_goal2.id, 2)]), 1):
|
|
obj_utils.create_test_audit_template(
|
|
self.context, id=id_, uuid=utils.generate_uuid(),
|
|
name='My Audit Template {0}'.format(id_),
|
|
goal_id=goal_id)
|
|
|
|
response = self.get_json(
|
|
'/audit_templates?goal=%s' % self.fake_goal2.uuid)
|
|
self.assertEqual(2, len(response['audit_templates']))
|
|
|
|
def test_filter_by_goal_name(self):
|
|
for id_, goal_id in enumerate(itertools.chain.from_iterable([
|
|
itertools.repeat(self.fake_goal1.id, 3),
|
|
itertools.repeat(self.fake_goal2.id, 2)]), 1):
|
|
obj_utils.create_test_audit_template(
|
|
self.context, id=id_, uuid=utils.generate_uuid(),
|
|
name='My Audit Template {0}'.format(id_),
|
|
goal_id=goal_id)
|
|
|
|
response = self.get_json(
|
|
'/audit_templates?goal=%s' % self.fake_goal2.name)
|
|
self.assertEqual(2, len(response['audit_templates']))
|
|
|
|
def test_filter_by_strategy_uuid(self):
|
|
for id_, strategy_id in enumerate(itertools.chain.from_iterable([
|
|
itertools.repeat(self.fake_strategy1.id, 3),
|
|
itertools.repeat(self.fake_strategy2.id, 2)]), 1):
|
|
obj_utils.create_test_audit_template(
|
|
self.context, id=id_, uuid=utils.generate_uuid(),
|
|
name='My Audit Template {0}'.format(id_),
|
|
strategy_id=strategy_id)
|
|
|
|
response = self.get_json(
|
|
'/audit_templates?strategy=%s' % self.fake_strategy2.uuid)
|
|
self.assertEqual(2, len(response['audit_templates']))
|
|
|
|
def test_filter_by_strategy_name(self):
|
|
for id_, strategy_id in enumerate(itertools.chain.from_iterable([
|
|
itertools.repeat(self.fake_strategy1.id, 3),
|
|
itertools.repeat(self.fake_strategy2.id, 2)]), 1):
|
|
obj_utils.create_test_audit_template(
|
|
self.context, id=id_, uuid=utils.generate_uuid(),
|
|
name='My Audit Template {0}'.format(id_),
|
|
strategy_id=strategy_id)
|
|
|
|
response = self.get_json(
|
|
'/audit_templates?strategy=%s' % self.fake_strategy2.name)
|
|
self.assertEqual(2, len(response['audit_templates']))
|
|
|
|
def test_many_with_sort_key_name(self):
|
|
audit_template_list = []
|
|
for id_ in range(1, 6):
|
|
audit_template = obj_utils.create_test_audit_template(
|
|
self.context, id=id_, uuid=utils.generate_uuid(),
|
|
name='My Audit Template {0}'.format(id_))
|
|
audit_template_list.append(audit_template)
|
|
|
|
response = self.get_json('/audit_templates?sort_key=%s' % 'name')
|
|
|
|
names = [s['name'] for s in response['audit_templates']]
|
|
|
|
self.assertEqual(
|
|
sorted([at.name for at in audit_template_list]),
|
|
names)
|
|
|
|
def test_many_with_sort_key_goal_name(self):
|
|
goal_names_list = []
|
|
for id_, goal_id in enumerate(itertools.chain.from_iterable([
|
|
itertools.repeat(self.fake_goal1.id, 3),
|
|
itertools.repeat(self.fake_goal2.id, 2)]), 1):
|
|
audit_template = obj_utils.create_test_audit_template(
|
|
self.context, id=id_, uuid=utils.generate_uuid(),
|
|
name='My Audit Template {0}'.format(id_),
|
|
goal_id=goal_id)
|
|
goal_names_list.append(audit_template.goal.name)
|
|
|
|
for direction in ['asc', 'desc']:
|
|
response = self.get_json(
|
|
'/audit_templates?sort_key={0}&sort_dir={1}'
|
|
.format('goal_name', direction))
|
|
|
|
goal_names = [s['goal_name'] for s in response['audit_templates']]
|
|
|
|
self.assertEqual(
|
|
sorted(goal_names_list, reverse=(direction == 'desc')),
|
|
goal_names)
|
|
|
|
def test_sort_key_validation(self):
|
|
response = self.get_json(
|
|
'/audit_templates?sort_key=%s' % 'goal_bad_name',
|
|
expect_errors=True)
|
|
self.assertEqual(HTTPStatus.BAD_REQUEST, response.status_int)
|
|
|
|
|
|
class TestPatch(FunctionalTestWithSetup):
|
|
|
|
def setUp(self):
|
|
super(TestPatch, self).setUp()
|
|
obj_utils.create_test_goal(self.context)
|
|
self.audit_template = obj_utils.create_test_audit_template(
|
|
self.context, strategy_id=None)
|
|
|
|
@mock.patch.object(timeutils, 'utcnow')
|
|
def test_replace_goal_uuid(self, mock_utcnow):
|
|
test_time = datetime.datetime(2000, 1, 1, 0, 0)
|
|
mock_utcnow.return_value = test_time
|
|
|
|
new_goal_uuid = self.fake_goal2.uuid
|
|
response = self.get_json(
|
|
'/audit_templates/%s' % self.audit_template.uuid)
|
|
self.assertNotEqual(new_goal_uuid, response['goal_uuid'])
|
|
|
|
response = self.patch_json(
|
|
'/audit_templates/%s' % self.audit_template.uuid,
|
|
[{'path': '/goal', 'value': new_goal_uuid,
|
|
'op': 'replace'}])
|
|
self.assertEqual('application/json', response.content_type)
|
|
self.assertEqual(HTTPStatus.OK, response.status_code)
|
|
|
|
response = self.get_json(
|
|
'/audit_templates/%s' % self.audit_template.uuid)
|
|
self.assertEqual(new_goal_uuid, response['goal_uuid'])
|
|
return_updated_at = timeutils.parse_isotime(
|
|
response['updated_at']).replace(tzinfo=None)
|
|
self.assertEqual(test_time, return_updated_at)
|
|
|
|
@mock.patch.object(timeutils, 'utcnow')
|
|
def test_replace_goal_uuid_by_name(self, mock_utcnow):
|
|
test_time = datetime.datetime(2000, 1, 1, 0, 0)
|
|
mock_utcnow.return_value = test_time
|
|
|
|
new_goal_uuid = self.fake_goal2.uuid
|
|
response = self.get_json(urlparse.quote(
|
|
'/audit_templates/%s' % self.audit_template.name))
|
|
self.assertNotEqual(new_goal_uuid, response['goal_uuid'])
|
|
|
|
response = self.patch_json(
|
|
'/audit_templates/%s' % self.audit_template.name,
|
|
[{'path': '/goal', 'value': new_goal_uuid,
|
|
'op': 'replace'}])
|
|
self.assertEqual('application/json', response.content_type)
|
|
self.assertEqual(HTTPStatus.OK, response.status_code)
|
|
|
|
response = self.get_json(
|
|
'/audit_templates/%s' % self.audit_template.name)
|
|
self.assertEqual(new_goal_uuid, response['goal_uuid'])
|
|
return_updated_at = timeutils.parse_isotime(
|
|
response['updated_at']).replace(tzinfo=None)
|
|
self.assertEqual(test_time, return_updated_at)
|
|
|
|
def test_replace_non_existent_audit_template(self):
|
|
response = self.patch_json(
|
|
'/audit_templates/%s' % utils.generate_uuid(),
|
|
[{'path': '/goal', 'value': self.fake_goal1.uuid,
|
|
'op': 'replace'}],
|
|
expect_errors=True)
|
|
self.assertEqual(HTTPStatus.NOT_FOUND, response.status_int)
|
|
self.assertEqual('application/json', response.content_type)
|
|
self.assertTrue(response.json['error_message'])
|
|
|
|
def test_replace_invalid_goal(self):
|
|
with mock.patch.object(
|
|
self.dbapi,
|
|
'update_audit_template',
|
|
wraps=self.dbapi.update_audit_template
|
|
) as cn_mock:
|
|
response = self.patch_json(
|
|
'/audit_templates/%s' % self.audit_template.uuid,
|
|
[{'path': '/goal', 'value': utils.generate_uuid(),
|
|
'op': 'replace'}],
|
|
expect_errors=True)
|
|
self.assertEqual(HTTPStatus.BAD_REQUEST, response.status_int)
|
|
assert not cn_mock.called
|
|
|
|
def test_add_goal_uuid(self):
|
|
response = self.patch_json(
|
|
'/audit_templates/%s' % self.audit_template.uuid,
|
|
[{'path': '/goal',
|
|
'value': self.fake_goal2.uuid,
|
|
'op': 'add'}])
|
|
self.assertEqual('application/json', response.content_type)
|
|
self.assertEqual(HTTPStatus.OK, response.status_int)
|
|
|
|
response = self.get_json(
|
|
'/audit_templates/%s' % self.audit_template.uuid)
|
|
self.assertEqual(self.fake_goal2.uuid, response['goal_uuid'])
|
|
|
|
def test_add_strategy_uuid(self):
|
|
response = self.patch_json(
|
|
'/audit_templates/%s' % self.audit_template.uuid,
|
|
[{'path': '/strategy',
|
|
'value': self.fake_strategy1.uuid,
|
|
'op': 'add'}])
|
|
self.assertEqual('application/json', response.content_type)
|
|
self.assertEqual(HTTPStatus.OK, response.status_int)
|
|
|
|
response = self.get_json(
|
|
'/audit_templates/%s' % self.audit_template.uuid)
|
|
self.assertEqual(self.fake_strategy1.uuid, response['strategy_uuid'])
|
|
|
|
def test_replace_strategy_uuid(self):
|
|
response = self.patch_json(
|
|
'/audit_templates/%s' % self.audit_template.uuid,
|
|
[{'path': '/strategy',
|
|
'value': self.fake_strategy2['uuid'],
|
|
'op': 'replace'}])
|
|
self.assertEqual('application/json', response.content_type)
|
|
self.assertEqual(HTTPStatus.OK, response.status_int)
|
|
|
|
response = self.get_json(
|
|
'/audit_templates/%s' % self.audit_template.uuid)
|
|
self.assertEqual(
|
|
self.fake_strategy2['uuid'], response['strategy_uuid'])
|
|
|
|
def test_replace_invalid_strategy(self):
|
|
response = self.patch_json(
|
|
'/audit_templates/%s' % self.audit_template.uuid,
|
|
[{'path': '/strategy',
|
|
'value': utils.generate_uuid(), # Does not exist
|
|
'op': 'replace'}], expect_errors=True)
|
|
self.assertEqual('application/json', response.content_type)
|
|
self.assertEqual(HTTPStatus.BAD_REQUEST, response.status_int)
|
|
self.assertTrue(response.json['error_message'])
|
|
|
|
def test_add_non_existent_property(self):
|
|
response = self.patch_json(
|
|
'/audit_templates/%s' % self.audit_template.uuid,
|
|
[{'path': '/foo', 'value': 'bar', 'op': 'add'}],
|
|
expect_errors=True)
|
|
self.assertEqual('application/json', response.content_type)
|
|
self.assertEqual(HTTPStatus.BAD_REQUEST, response.status_int)
|
|
self.assertTrue(response.json['error_message'])
|
|
|
|
def test_remove_strategy(self):
|
|
audit_template = obj_utils.create_test_audit_template(
|
|
self.context, uuid=utils.generate_uuid(),
|
|
name="AT_%s" % utils.generate_uuid(),
|
|
goal_id=self.fake_goal1.id,
|
|
strategy_id=self.fake_strategy1.id)
|
|
response = self.get_json(
|
|
'/audit_templates/%s' % audit_template.uuid)
|
|
self.assertIsNotNone(response['strategy_uuid'])
|
|
|
|
response = self.patch_json(
|
|
'/audit_templates/%s' % self.audit_template.uuid,
|
|
[{'path': '/strategy', 'op': 'remove'}])
|
|
self.assertEqual('application/json', response.content_type)
|
|
self.assertEqual(HTTPStatus.OK, response.status_code)
|
|
|
|
def test_remove_goal(self):
|
|
response = self.get_json(
|
|
'/audit_templates/%s' % self.audit_template.uuid)
|
|
self.assertIsNotNone(response['goal_uuid'])
|
|
|
|
response = self.patch_json(
|
|
'/audit_templates/%s' % self.audit_template.uuid,
|
|
[{'path': '/goal', 'op': 'remove'}],
|
|
expect_errors=True)
|
|
self.assertEqual(HTTPStatus.FORBIDDEN, response.status_code)
|
|
self.assertEqual('application/json', response.content_type)
|
|
self.assertTrue(response.json['error_message'])
|
|
|
|
def test_remove_uuid(self):
|
|
response = self.patch_json(
|
|
'/audit_templates/%s' % self.audit_template.uuid,
|
|
[{'path': '/uuid', 'op': 'remove'}],
|
|
expect_errors=True)
|
|
self.assertEqual(HTTPStatus.BAD_REQUEST, response.status_int)
|
|
self.assertEqual('application/json', response.content_type)
|
|
self.assertTrue(response.json['error_message'])
|
|
|
|
def test_remove_non_existent_property(self):
|
|
response = self.patch_json(
|
|
'/audit_templates/%s' % self.audit_template.uuid,
|
|
[{'path': '/non-existent', 'op': 'remove'}],
|
|
expect_errors=True)
|
|
self.assertEqual(HTTPStatus.BAD_REQUEST, response.status_code)
|
|
self.assertEqual('application/json', response.content_type)
|
|
self.assertTrue(response.json['error_message'])
|
|
|
|
|
|
class TestPost(FunctionalTestWithSetup):
|
|
|
|
@mock.patch.object(timeutils, 'utcnow')
|
|
def test_create_audit_template(self, mock_utcnow):
|
|
audit_template_dict = post_get_test_audit_template(
|
|
goal=self.fake_goal1.uuid,
|
|
strategy=self.fake_strategy1.uuid)
|
|
test_time = datetime.datetime(2000, 1, 1, 0, 0)
|
|
mock_utcnow.return_value = test_time
|
|
|
|
response = self.post_json('/audit_templates', audit_template_dict)
|
|
self.assertEqual('application/json', response.content_type)
|
|
self.assertEqual(HTTPStatus.CREATED, response.status_int)
|
|
# Check location header
|
|
self.assertIsNotNone(response.location)
|
|
expected_location = \
|
|
'/v1/audit_templates/%s' % response.json['uuid']
|
|
self.assertEqual(urlparse.urlparse(response.location).path,
|
|
expected_location)
|
|
self.assertTrue(utils.is_uuid_like(response.json['uuid']))
|
|
self.assertNotIn('updated_at', response.json.keys)
|
|
self.assertNotIn('deleted_at', response.json.keys)
|
|
self.assertEqual(self.fake_goal1.uuid, response.json['goal_uuid'])
|
|
self.assertEqual(self.fake_strategy1.uuid,
|
|
response.json['strategy_uuid'])
|
|
return_created_at = timeutils.parse_isotime(
|
|
response.json['created_at']).replace(tzinfo=None)
|
|
self.assertEqual(test_time, return_created_at)
|
|
|
|
@mock.patch.object(timeutils, 'utcnow')
|
|
def test_create_audit_template_with_strategy_name(self, mock_utcnow):
|
|
audit_template_dict = post_get_test_audit_template(
|
|
goal=self.fake_goal1.uuid,
|
|
strategy=self.fake_strategy1.name)
|
|
test_time = datetime.datetime(2000, 1, 1, 0, 0)
|
|
mock_utcnow.return_value = test_time
|
|
|
|
response = self.post_json('/audit_templates', audit_template_dict)
|
|
self.assertEqual('application/json', response.content_type)
|
|
self.assertEqual(HTTPStatus.CREATED, response.status_int)
|
|
# Check location header
|
|
self.assertIsNotNone(response.location)
|
|
expected_location = \
|
|
'/v1/audit_templates/%s' % response.json['uuid']
|
|
self.assertEqual(urlparse.urlparse(response.location).path,
|
|
expected_location)
|
|
self.assertTrue(utils.is_uuid_like(response.json['uuid']))
|
|
self.assertNotIn('updated_at', response.json.keys)
|
|
self.assertNotIn('deleted_at', response.json.keys)
|
|
self.assertEqual(self.fake_goal1.uuid, response.json['goal_uuid'])
|
|
self.assertEqual(self.fake_strategy1.uuid,
|
|
response.json['strategy_uuid'])
|
|
self.assertEqual(self.fake_strategy1.name,
|
|
response.json['strategy_name'])
|
|
return_created_at = timeutils.parse_isotime(
|
|
response.json['created_at']).replace(tzinfo=None)
|
|
self.assertEqual(test_time, return_created_at)
|
|
|
|
def test_create_audit_template_validation_with_aggregates(self):
|
|
scope = [{'compute': [{'host_aggregates': [{'id': '*'}]},
|
|
{'availability_zones': [{'name': 'AZ1'},
|
|
{'name': 'AZ2'}]},
|
|
{'exclude': [
|
|
{'instances': [
|
|
{'uuid': 'INSTANCE_1'},
|
|
{'uuid': 'INSTANCE_2'}]},
|
|
{'compute_nodes': [
|
|
{'name': 'Node_1'},
|
|
{'name': 'Node_2'}]},
|
|
{'host_aggregates': [{'id': '*'}]}
|
|
]}
|
|
]
|
|
}
|
|
]
|
|
audit_template_dict = post_get_test_audit_template(
|
|
goal=self.fake_goal1.uuid,
|
|
strategy=self.fake_strategy1.uuid, scope=scope)
|
|
with self.assertRaisesRegex(webtest_app.AppError,
|
|
"be included and excluded together"):
|
|
self.post_json('/audit_templates', audit_template_dict)
|
|
|
|
scope = [{'host_aggregates': [{'id1': '*'}]}]
|
|
audit_template_dict = post_get_test_audit_template(
|
|
goal=self.fake_goal1.uuid,
|
|
strategy=self.fake_strategy1.uuid, scope=scope)
|
|
response = self.post_json('/audit_templates',
|
|
audit_template_dict, expect_errors=True)
|
|
self.assertEqual(HTTPStatus.INTERNAL_SERVER_ERROR,
|
|
response.status_int)
|
|
|
|
def test_create_audit_template_does_autogenerate_id(self):
|
|
audit_template_dict = post_get_test_audit_template(
|
|
goal=self.fake_goal1.uuid, strategy=None)
|
|
with mock.patch.object(
|
|
self.dbapi,
|
|
'create_audit_template',
|
|
wraps=self.dbapi.create_audit_template
|
|
) as cn_mock:
|
|
response = self.post_json('/audit_templates', audit_template_dict)
|
|
self.assertEqual(audit_template_dict['goal'],
|
|
response.json['goal_uuid'])
|
|
# Check that 'id' is not in first arg of positional args
|
|
self.assertNotIn('id', cn_mock.call_args[0][0])
|
|
|
|
def test_create_audit_template_generate_uuid(self):
|
|
audit_template_dict = post_get_test_audit_template(
|
|
goal=self.fake_goal1.uuid, strategy=None)
|
|
|
|
response = self.post_json('/audit_templates', audit_template_dict)
|
|
self.assertEqual('application/json', response.content_type)
|
|
self.assertEqual(HTTPStatus.CREATED, response.status_int)
|
|
self.assertTrue(utils.is_uuid_like(response.json['uuid']))
|
|
|
|
def test_create_audit_template_with_invalid_goal(self):
|
|
with mock.patch.object(
|
|
self.dbapi,
|
|
'create_audit_template',
|
|
wraps=self.dbapi.create_audit_template
|
|
) as cn_mock:
|
|
audit_template_dict = post_get_test_audit_template(
|
|
goal_uuid=utils.generate_uuid())
|
|
response = self.post_json('/audit_templates',
|
|
audit_template_dict, expect_errors=True)
|
|
self.assertEqual(HTTPStatus.BAD_REQUEST, response.status_int)
|
|
assert not cn_mock.called
|
|
|
|
def test_create_audit_template_with_invalid_strategy(self):
|
|
with mock.patch.object(
|
|
self.dbapi,
|
|
'create_audit_template',
|
|
wraps=self.dbapi.create_audit_template
|
|
) as cn_mock:
|
|
audit_template_dict = post_get_test_audit_template(
|
|
goal_uuid=self.fake_goal1['uuid'],
|
|
strategy_uuid=utils.generate_uuid())
|
|
response = self.post_json('/audit_templates',
|
|
audit_template_dict, expect_errors=True)
|
|
self.assertEqual(HTTPStatus.BAD_REQUEST, response.status_int)
|
|
assert not cn_mock.called
|
|
|
|
def test_create_audit_template_with_unrelated_strategy(self):
|
|
with mock.patch.object(
|
|
self.dbapi,
|
|
'create_audit_template',
|
|
wraps=self.dbapi.create_audit_template
|
|
) as cn_mock:
|
|
audit_template_dict = post_get_test_audit_template(
|
|
goal_uuid=self.fake_goal1['uuid'],
|
|
strategy=self.fake_strategy2['uuid'])
|
|
response = self.post_json('/audit_templates',
|
|
audit_template_dict, expect_errors=True)
|
|
self.assertEqual(HTTPStatus.BAD_REQUEST, response.status_int)
|
|
assert not cn_mock.called
|
|
|
|
def test_create_audit_template_with_uuid(self):
|
|
with mock.patch.object(
|
|
self.dbapi,
|
|
'create_audit_template',
|
|
wraps=self.dbapi.create_audit_template
|
|
) as cn_mock:
|
|
audit_template_dict = post_get_test_audit_template()
|
|
response = self.post_json('/audit_templates', audit_template_dict,
|
|
expect_errors=True)
|
|
self.assertEqual('application/json', response.content_type)
|
|
self.assertEqual(HTTPStatus.BAD_REQUEST, response.status_int)
|
|
assert not cn_mock.called
|
|
|
|
def test_create_audit_template_with_old_scope(self):
|
|
scope = [{'host_aggregates': [{'id': '*'}]},
|
|
{'availability_zones': [{'name': 'AZ1'},
|
|
{'name': 'AZ2'}]},
|
|
{'exclude': [
|
|
{'instances': [
|
|
{'uuid': 'INSTANCE_1'},
|
|
{'uuid': 'INSTANCE_2'}]},
|
|
{'compute_nodes': [
|
|
{'name': 'Node_1'},
|
|
{'name': 'Node_2'}]},
|
|
]}
|
|
]
|
|
audit_template_dict = post_get_test_audit_template(
|
|
goal=self.fake_goal1.uuid,
|
|
strategy=self.fake_strategy1.uuid, scope=scope)
|
|
response = self.post_json('/audit_templates',
|
|
audit_template_dict)
|
|
self.assertEqual(HTTPStatus.CREATED, response.status_int)
|
|
|
|
|
|
class TestDelete(api_base.FunctionalTest):
|
|
|
|
def setUp(self):
|
|
super(TestDelete, self).setUp()
|
|
obj_utils.create_test_goal(self.context)
|
|
self.audit_template = obj_utils.create_test_audit_template(
|
|
self.context)
|
|
|
|
@mock.patch.object(timeutils, 'utcnow')
|
|
def test_delete_audit_template_by_uuid(self, mock_utcnow):
|
|
test_time = datetime.datetime(2000, 1, 1, 0, 0)
|
|
mock_utcnow.return_value = test_time
|
|
self.delete(urlparse.quote('/audit_templates/%s' %
|
|
self.audit_template.uuid))
|
|
response = self.get_json(
|
|
urlparse.quote('/audit_templates/%s' % self.audit_template.uuid),
|
|
expect_errors=True)
|
|
self.assertEqual(HTTPStatus.NOT_FOUND, response.status_int)
|
|
self.assertEqual('application/json', response.content_type)
|
|
self.assertTrue(response.json['error_message'])
|
|
|
|
self.assertRaises(exception.AuditTemplateNotFound,
|
|
objects.AuditTemplate.get_by_uuid,
|
|
self.context,
|
|
self.audit_template.uuid)
|
|
|
|
self.context.show_deleted = True
|
|
at = objects.AuditTemplate.get_by_uuid(self.context,
|
|
self.audit_template.uuid)
|
|
self.assertEqual(self.audit_template.name, at.name)
|
|
|
|
@mock.patch.object(timeutils, 'utcnow')
|
|
def test_delete_audit_template_by_name(self, mock_utcnow):
|
|
test_time = datetime.datetime(2000, 1, 1, 0, 0)
|
|
mock_utcnow.return_value = test_time
|
|
self.delete(urlparse.quote('/audit_templates/%s' %
|
|
self.audit_template.name))
|
|
response = self.get_json(
|
|
urlparse.quote('/audit_templates/%s' % self.audit_template.name),
|
|
expect_errors=True)
|
|
self.assertEqual(HTTPStatus.NOT_FOUND, response.status_int)
|
|
self.assertEqual('application/json', response.content_type)
|
|
self.assertTrue(response.json['error_message'])
|
|
|
|
self.assertRaises(exception.AuditTemplateNotFound,
|
|
objects.AuditTemplate.get_by_name,
|
|
self.context,
|
|
self.audit_template.name)
|
|
|
|
self.context.show_deleted = True
|
|
at = objects.AuditTemplate.get_by_name(self.context,
|
|
self.audit_template.name)
|
|
self.assertEqual(self.audit_template.uuid, at.uuid)
|
|
|
|
def test_delete_audit_template_not_found(self):
|
|
uuid = utils.generate_uuid()
|
|
response = self.delete(
|
|
'/audit_templates/%s' % uuid, expect_errors=True)
|
|
self.assertEqual(HTTPStatus.NOT_FOUND, response.status_int)
|
|
self.assertEqual('application/json', response.content_type)
|
|
self.assertTrue(response.json['error_message'])
|
|
|
|
|
|
class TestAuditTemplatePolicyEnforcement(api_base.FunctionalTest):
|
|
|
|
def _common_policy_check(self, rule, func, *arg, **kwarg):
|
|
self.policy.set_rules({
|
|
"admin_api": "(role:admin or role:administrator)",
|
|
"default": "rule:admin_api",
|
|
rule: "rule:default"})
|
|
response = func(*arg, **kwarg)
|
|
self.assertEqual(HTTPStatus.FORBIDDEN, response.status_int)
|
|
self.assertEqual('application/json', response.content_type)
|
|
self.assertTrue(
|
|
"Policy doesn't allow %s to be performed." % rule,
|
|
jsonutils.loads(response.json['error_message'])['faultstring'])
|
|
|
|
def test_policy_disallow_get_all(self):
|
|
self._common_policy_check(
|
|
"audit_template:get_all", self.get_json, '/audit_templates',
|
|
expect_errors=True)
|
|
|
|
def test_policy_disallow_get_one(self):
|
|
obj_utils.create_test_goal(self.context)
|
|
audit_template = obj_utils.create_test_audit_template(self.context)
|
|
self._common_policy_check(
|
|
"audit_template:get", self.get_json,
|
|
'/audit_templates/%s' % audit_template.uuid,
|
|
expect_errors=True)
|
|
|
|
def test_policy_disallow_detail(self):
|
|
self._common_policy_check(
|
|
"audit_template:detail", self.get_json,
|
|
'/audit_templates/detail',
|
|
expect_errors=True)
|
|
|
|
def test_policy_disallow_update(self):
|
|
obj_utils.create_test_goal(self.context)
|
|
audit_template = obj_utils.create_test_audit_template(self.context)
|
|
self._common_policy_check(
|
|
"audit_template:update", self.patch_json,
|
|
'/audit_templates/%s' % audit_template.uuid,
|
|
[{'path': '/state', 'value': objects.audit.State.SUCCEEDED,
|
|
'op': 'replace'}], expect_errors=True)
|
|
|
|
def test_policy_disallow_create(self):
|
|
fake_goal1 = obj_utils.get_test_goal(
|
|
self.context, id=1, uuid=utils.generate_uuid(), name="dummy_1")
|
|
fake_goal1.create()
|
|
fake_strategy1 = obj_utils.get_test_strategy(
|
|
self.context, id=1, uuid=utils.generate_uuid(), name="strategy_1",
|
|
goal_id=fake_goal1.id)
|
|
fake_strategy1.create()
|
|
|
|
audit_template_dict = post_get_test_audit_template(
|
|
goal=fake_goal1.uuid,
|
|
strategy=fake_strategy1.uuid)
|
|
self._common_policy_check(
|
|
"audit_template:create", self.post_json, '/audit_templates',
|
|
audit_template_dict, expect_errors=True)
|
|
|
|
def test_policy_disallow_delete(self):
|
|
obj_utils.create_test_goal(self.context)
|
|
audit_template = obj_utils.create_test_audit_template(self.context)
|
|
self._common_policy_check(
|
|
"audit_template:delete", self.delete,
|
|
'/audit_templates/%s' % audit_template.uuid, expect_errors=True)
|
|
|
|
|
|
class TestAuditTemplatePolicyWithAdminContext(TestListAuditTemplate,
|
|
api_base.AdminRoleTest):
|
|
def setUp(self):
|
|
super(TestAuditTemplatePolicyWithAdminContext, self).setUp()
|
|
self.policy.set_rules({
|
|
"admin_api": "(role:admin or role:administrator)",
|
|
"default": "rule:admin_api",
|
|
"audit_template:create": "rule:default",
|
|
"audit_template:delete": "rule:default",
|
|
"audit_template:detail": "rule:default",
|
|
"audit_template:get": "rule:default",
|
|
"audit_template:get_all": "rule:default",
|
|
"audit_template:update": "rule:default"})
|