8a36ad5f87
Now that we no longer support py27, we can use the standard library
unittest.mock module instead of the third party mock lib.
The remainder was auto-generated with the following (hacky) script, with
one or two manual tweaks after the fact:
import glob
for path in glob.glob('watcher/tests/**/*.py', recursive=True):
with open(path) as fh:
lines = fh.readlines()
if 'import mock\n' not in lines:
continue
import_group_found = False
create_first_party_group = False
for num, line in enumerate(lines):
line = line.strip()
if line.startswith('import ') or line.startswith('from '):
tokens = line.split()
for lib in (
'ddt', 'six', 'webob', 'fixtures', 'testtools'
'neutron', 'cinder', 'ironic', 'keystone', 'oslo',
):
if lib in tokens[1]:
create_first_party_group = True
break
if create_first_party_group:
break
import_group_found = True
if not import_group_found:
continue
if line.startswith('import ') or line.startswith('from '):
tokens = line.split()
if tokens[1] > 'unittest':
break
elif tokens[1] == 'unittest' and (
len(tokens) == 2 or tokens[4] > 'mock'
):
break
elif not line:
break
if create_first_party_group:
lines.insert(num, 'from unittest import mock\n\n')
else:
lines.insert(num, 'from unittest import mock\n')
del lines[lines.index('import mock\n')]
with open(path, 'w+') as fh:
fh.writelines(lines)
Co-Authored-By: Sean McGinnis <sean.mcginnis@gmail.com>
Change-Id: Icf35d3a6c10c529e07d1a4edaa36f504e5bf553a
303 lines
12 KiB
Python
303 lines
12 KiB
Python
# Licensed under the Apache License, Version 2.0 (the "License");
|
|
# you may not use this file except in compliance with the License.
|
|
# You may obtain a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
# distributed under the License is distributed on an "AS IS" BASIS,
|
|
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
# See the License for the specific language governing permissions and
|
|
# limitations under the License.
|
|
|
|
from unittest import mock
|
|
from urllib import parse as urlparse
|
|
|
|
from oslo_config import cfg
|
|
from oslo_serialization import jsonutils
|
|
|
|
from watcher.common import utils
|
|
from watcher.decision_engine import rpcapi as deapi
|
|
from watcher.tests.api import base as api_base
|
|
from watcher.tests.objects import utils as obj_utils
|
|
|
|
|
|
class TestListStrategy(api_base.FunctionalTest):
|
|
|
|
def setUp(self):
|
|
super(TestListStrategy, self).setUp()
|
|
self.fake_goal = obj_utils.create_test_goal(
|
|
self.context, uuid=utils.generate_uuid())
|
|
|
|
def _assert_strategy_fields(self, strategy):
|
|
strategy_fields = ['uuid', 'name', 'display_name', 'goal_uuid']
|
|
for field in strategy_fields:
|
|
self.assertIn(field, strategy)
|
|
|
|
@mock.patch.object(deapi.DecisionEngineAPI, 'get_strategy_info')
|
|
def test_state(self, mock_strategy_info):
|
|
strategy = obj_utils.create_test_strategy(self.context)
|
|
mock_state = [
|
|
{"type": "Datasource", "mandatory": True, "comment": "",
|
|
"state": "gnocchi: True"},
|
|
{"type": "Metrics", "mandatory": False, "comment": "",
|
|
"state": [{"compute.node.cpu.percent": "available"},
|
|
{"cpu_util": "available"}]},
|
|
{"type": "CDM", "mandatory": True, "comment": "",
|
|
"state": [{"compute_model": "available"},
|
|
{"storage_model": "not available"}]},
|
|
{"type": "Name", "mandatory": "", "comment": "",
|
|
"state": strategy.name}
|
|
]
|
|
|
|
mock_strategy_info.return_value = mock_state
|
|
response = self.get_json('/strategies/%s/state' % strategy.uuid)
|
|
strategy_name = [requirement["state"] for requirement in response
|
|
if requirement["type"] == "Name"][0]
|
|
self.assertEqual(strategy.name, strategy_name)
|
|
|
|
def test_one(self):
|
|
strategy = obj_utils.create_test_strategy(self.context)
|
|
response = self.get_json('/strategies')
|
|
self.assertEqual(strategy.uuid, response['strategies'][0]["uuid"])
|
|
self._assert_strategy_fields(response['strategies'][0])
|
|
|
|
def test_get_one_by_uuid(self):
|
|
strategy = obj_utils.create_test_strategy(self.context)
|
|
response = self.get_json('/strategies/%s' % strategy.uuid)
|
|
self.assertEqual(strategy.uuid, response["uuid"])
|
|
self.assertEqual(strategy.name, response["name"])
|
|
self._assert_strategy_fields(response)
|
|
|
|
def test_get_one_by_name(self):
|
|
strategy = obj_utils.create_test_strategy(self.context)
|
|
response = self.get_json(urlparse.quote(
|
|
'/strategies/%s' % strategy['name']))
|
|
self.assertEqual(strategy.uuid, response['uuid'])
|
|
self._assert_strategy_fields(response)
|
|
|
|
def test_get_one_soft_deleted(self):
|
|
strategy = obj_utils.create_test_strategy(self.context)
|
|
strategy.soft_delete()
|
|
response = self.get_json(
|
|
'/strategies/%s' % strategy['uuid'],
|
|
headers={'X-Show-Deleted': 'True'})
|
|
self.assertEqual(strategy.uuid, response['uuid'])
|
|
self._assert_strategy_fields(response)
|
|
|
|
response = self.get_json(
|
|
'/strategies/%s' % strategy['uuid'],
|
|
expect_errors=True)
|
|
self.assertEqual(404, response.status_int)
|
|
|
|
def test_detail(self):
|
|
strategy = obj_utils.create_test_strategy(self.context)
|
|
response = self.get_json('/strategies/detail')
|
|
self.assertEqual(strategy.uuid, response['strategies'][0]["uuid"])
|
|
self._assert_strategy_fields(response['strategies'][0])
|
|
for strategy in response['strategies']:
|
|
self.assertTrue(
|
|
all(val is not None for key, val in strategy.items()
|
|
if key in ['uuid', 'name', 'display_name', 'goal_uuid']))
|
|
|
|
def test_detail_against_single(self):
|
|
strategy = obj_utils.create_test_strategy(self.context)
|
|
response = self.get_json('/strategies/%s/detail' % strategy.uuid,
|
|
expect_errors=True)
|
|
self.assertEqual(404, response.status_int)
|
|
|
|
def test_many(self):
|
|
strategy_list = []
|
|
for idx in range(1, 6):
|
|
strategy = obj_utils.create_test_strategy(
|
|
self.context, id=idx,
|
|
uuid=utils.generate_uuid(),
|
|
name='STRATEGY_{0}'.format(idx))
|
|
strategy_list.append(strategy.uuid)
|
|
response = self.get_json('/strategies')
|
|
self.assertEqual(5, len(response['strategies']))
|
|
for strategy in response['strategies']:
|
|
self.assertTrue(
|
|
all(val is not None for key, val in strategy.items()
|
|
if key in ['uuid', 'name', 'display_name', 'goal_uuid']))
|
|
|
|
def test_many_without_soft_deleted(self):
|
|
strategy_list = []
|
|
for id_ in [1, 2, 3]:
|
|
strategy = obj_utils.create_test_strategy(
|
|
self.context, id=id_, uuid=utils.generate_uuid(),
|
|
name='STRATEGY_{0}'.format(id_))
|
|
strategy_list.append(strategy.uuid)
|
|
for id_ in [4, 5]:
|
|
strategy = obj_utils.create_test_strategy(
|
|
self.context, id=id_, uuid=utils.generate_uuid(),
|
|
name='STRATEGY_{0}'.format(id_))
|
|
strategy.soft_delete()
|
|
response = self.get_json('/strategies')
|
|
self.assertEqual(3, len(response['strategies']))
|
|
uuids = [s['uuid'] for s in response['strategies']]
|
|
self.assertEqual(sorted(strategy_list), sorted(uuids))
|
|
|
|
def test_strategies_collection_links(self):
|
|
for idx in range(1, 6):
|
|
obj_utils.create_test_strategy(
|
|
self.context, id=idx,
|
|
uuid=utils.generate_uuid(),
|
|
name='STRATEGY_{0}'.format(idx))
|
|
response = self.get_json('/strategies/?limit=2')
|
|
self.assertEqual(2, len(response['strategies']))
|
|
|
|
def test_strategies_collection_links_default_limit(self):
|
|
for idx in range(1, 6):
|
|
obj_utils.create_test_strategy(
|
|
self.context, id=idx,
|
|
uuid=utils.generate_uuid(),
|
|
name='STRATEGY_{0}'.format(idx))
|
|
cfg.CONF.set_override('max_limit', 3, 'api')
|
|
response = self.get_json('/strategies')
|
|
self.assertEqual(3, len(response['strategies']))
|
|
|
|
def test_filter_by_goal_uuid(self):
|
|
goal1 = obj_utils.create_test_goal(
|
|
self.context,
|
|
id=2,
|
|
uuid=utils.generate_uuid(),
|
|
name='My_Goal 1')
|
|
goal2 = obj_utils.create_test_goal(
|
|
self.context,
|
|
id=3,
|
|
uuid=utils.generate_uuid(),
|
|
name='My Goal 2')
|
|
|
|
for id_ in range(1, 3):
|
|
obj_utils.create_test_strategy(
|
|
self.context, id=id_,
|
|
uuid=utils.generate_uuid(),
|
|
name='Goal %s' % id_,
|
|
goal_id=goal1['id'])
|
|
for id_ in range(3, 5):
|
|
obj_utils.create_test_strategy(
|
|
self.context, id=id_,
|
|
uuid=utils.generate_uuid(),
|
|
name='Goal %s' % id_,
|
|
goal_id=goal2['id'])
|
|
|
|
response = self.get_json('/strategies/?goal=%s' % goal1['uuid'])
|
|
|
|
strategies = response['strategies']
|
|
self.assertEqual(2, len(strategies))
|
|
for strategy in strategies:
|
|
self.assertEqual(goal1['uuid'], strategy['goal_uuid'])
|
|
|
|
def test_filter_by_goal_name(self):
|
|
goal1 = obj_utils.create_test_goal(
|
|
self.context,
|
|
id=2,
|
|
uuid=utils.generate_uuid(),
|
|
name='My_Goal 1')
|
|
goal2 = obj_utils.create_test_goal(
|
|
self.context,
|
|
id=3,
|
|
uuid=utils.generate_uuid(),
|
|
name='My Goal 2')
|
|
|
|
for id_ in range(1, 3):
|
|
obj_utils.create_test_strategy(
|
|
self.context, id=id_,
|
|
uuid=utils.generate_uuid(),
|
|
name='Goal %s' % id_,
|
|
goal_id=goal1['id'])
|
|
for id_ in range(3, 5):
|
|
obj_utils.create_test_strategy(
|
|
self.context, id=id_,
|
|
uuid=utils.generate_uuid(),
|
|
name='Goal %s' % id_,
|
|
goal_id=goal2['id'])
|
|
|
|
response = self.get_json('/strategies/?goal=%s' % goal1['name'])
|
|
|
|
strategies = response['strategies']
|
|
self.assertEqual(2, len(strategies))
|
|
for strategy in strategies:
|
|
self.assertEqual(goal1['uuid'], strategy['goal_uuid'])
|
|
|
|
def test_many_with_sort_key_goal_uuid(self):
|
|
goals_uuid_list = []
|
|
for idx in range(1, 6):
|
|
strategy = obj_utils.create_test_strategy(
|
|
self.context, id=idx,
|
|
uuid=utils.generate_uuid(),
|
|
name='STRATEGY_{0}'.format(idx))
|
|
goals_uuid_list.append(strategy.goal.uuid)
|
|
|
|
response = self.get_json('/strategies/?sort_key=goal_uuid')
|
|
|
|
self.assertEqual(5, len(response['strategies']))
|
|
goal_uuids = [s['goal_uuid'] for s in response['strategies']]
|
|
self.assertEqual(sorted(goals_uuid_list), goal_uuids)
|
|
|
|
def test_sort_key_validation(self):
|
|
response = self.get_json(
|
|
'/strategies?sort_key=%s' % 'bad_name',
|
|
expect_errors=True)
|
|
self.assertEqual(400, response.status_int)
|
|
|
|
|
|
class TestStrategyPolicyEnforcement(api_base.FunctionalTest):
|
|
|
|
def setUp(self):
|
|
super(TestStrategyPolicyEnforcement, self).setUp()
|
|
self.fake_goal = obj_utils.create_test_goal(
|
|
self.context, uuid=utils.generate_uuid())
|
|
|
|
def _common_policy_check(self, rule, func, *arg, **kwarg):
|
|
self.policy.set_rules({
|
|
"admin_api": "(role:admin or role:administrator)",
|
|
"default": "rule:admin_api",
|
|
rule: "rule:defaut"})
|
|
response = func(*arg, **kwarg)
|
|
self.assertEqual(403, response.status_int)
|
|
self.assertEqual('application/json', response.content_type)
|
|
self.assertTrue(
|
|
"Policy doesn't allow %s to be performed." % rule,
|
|
jsonutils.loads(response.json['error_message'])['faultstring'])
|
|
|
|
def test_policy_disallow_get_all(self):
|
|
self._common_policy_check(
|
|
"strategy:get_all", self.get_json, '/strategies',
|
|
expect_errors=True)
|
|
|
|
def test_policy_disallow_get_one(self):
|
|
strategy = obj_utils.create_test_strategy(self.context)
|
|
self._common_policy_check(
|
|
"strategy:get", self.get_json,
|
|
'/strategies/%s' % strategy.uuid,
|
|
expect_errors=True)
|
|
|
|
def test_policy_disallow_detail(self):
|
|
self._common_policy_check(
|
|
"strategy:detail", self.get_json,
|
|
'/strategies/detail',
|
|
expect_errors=True)
|
|
|
|
def test_policy_disallow_state(self):
|
|
strategy = obj_utils.create_test_strategy(self.context)
|
|
self._common_policy_check(
|
|
"strategy:get", self.get_json,
|
|
'/strategies/%s/state' % strategy.uuid,
|
|
expect_errors=True)
|
|
|
|
|
|
class TestStrategyEnforcementWithAdminContext(
|
|
TestListStrategy, api_base.AdminRoleTest):
|
|
|
|
def setUp(self):
|
|
super(TestStrategyEnforcementWithAdminContext, self).setUp()
|
|
self.policy.set_rules({
|
|
"admin_api": "(role:admin or role:administrator)",
|
|
"default": "rule:admin_api",
|
|
"strategy:detail": "rule:default",
|
|
"strategy:get": "rule:default",
|
|
"strategy:get_all": "rule:default",
|
|
"strategy:state": "rule:default"})
|