Arnike/watcher
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

optimize update_audit_state

Browse Source 
save state only if the state is different with audit.state

Change-Id: Ida5156f2e63be55e8dd7de452965270c007ab4ab
This commit is contained in:
licanwei
2017-10-07 00:59:42 -07:00
parent fa7749ac8f
commit 7f9b562bbd
2 changed files with 4 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
watcher/decision_engine/audit/base.py
View File

@@ -96,9 +96,10 @@ class AuditHandler(BaseAuditHandler):
raise raise
def update_audit_state(self, audit, state): def update_audit_state(self, audit, state):
LOG.debug("Update audit state: %s", state) if audit.state != state:
audit.state = state LOG.debug("Update audit state: %s", state)
audit.save() audit.state = state
audit.save()
def check_ongoing_action_plans(self, request_context): def check_ongoing_action_plans(self, request_context):
a_plan_filters = {'state': objects.action_plan.State.ONGOING} a_plan_filters = {'state': objects.action_plan.State.ONGOING}

2
watcher/tests/decision_engine/audit/test_audit_handlers.py
View File

@@ -338,8 +338,6 @@ class TestContinuousAuditHandler(base.DbTestCase):
mock_jobs.return_value = mock.MagicMock() mock_jobs.return_value = mock.MagicMock()
m_service.return_value = mock.MagicMock() m_service.return_value = mock.MagicMock()
m_engine.return_value = mock.MagicMock() m_engine.return_value = mock.MagicMock()
self.audits[1].state = objects.audit.State.CANCELLED
self.audits[0].state = objects.audit.State.SUSPENDED
ap_jobs = [job.Job(mock.MagicMock(), name='execute_audit', ap_jobs = [job.Job(mock.MagicMock(), name='execute_audit',
func=audit_handler.execute_audit, func=audit_handler.execute_audit,