Even though Watcher was mentioning python 3.4 as supported, it
really wasn't the case as all the unit tests were not passing in this
version of Python.
This patchset fixes all the failing tests in Python 3.4 while
keeping Watcher Python 2.7 compatible.
DocImpact
BugImpact
Change-Id: Ie74acc08ef0a2899349a4b419728c89e416a18cb
As the coverage on the nova wrapper is actually very low, this
patchset is here to raise it a bit since it is a quite central
piece of code.
Change-Id: Ie7879c74c8d322d5031953827c339bb11d9085c1
In the file tox.ini we have some pep8 rules disabled.
We should remove H404,H405,H305 from the ignore list.
Removed them from the ignore list, and got some errors.
I restructured the comments, and now with H404, H405, H305 enabled,
pep8 works without any failures.
Change-Id: Ic2aeb2a8bd47e92fbd2bb0f43fd00d44b6c220ca
Closes-Bug: #1523841
In basic_consolidation.py has a method, called calculate_score_vm().
This method used to get vm's id as a parameter, but it was replaced
and now it gets the vm as a parameter. So we don't need to get the
vm from our vm's id, as we already have the vm.
Change-Id: I96af7fbdbe85eda8d4fc44b4b162e8ba9d4967fa
In basic_consolidation.py there is a method called calculate_score_vm()
which had two return statements following each other. The second one
(which equals the first one) is unreachable as the first one returns.
Change-Id: Ia4877c22188fae6217e07597a2dd939633414349
Closes-Bug: #1524911
Some Python class and packages need to be renamed
for a better compliance with the shared terminology
which provides a better understanding of Watcher
objects and components by every contributor.
This patchset is there to change mapper to mapping
Partially implements: blueprint glossary-related-refactoring
Change-Id: Ieaca42431322ce40d87de147ac0b46a1f446f390
Some Python class and packages need to be renamed
for a better compliance with the shared terminology
which provides a better understanding of Watcher
objects and components by every contributor.
This patchset is there to change
Primitive to Primitives.
Add BasePrimitive.
Partially implements: blueprint glossary-related-refactoring
Change-Id: I839bddd12b5320b338b2f207d74963afa23de522
As Openstack Liberty now targets Python 2.7 and 3.4,
we should drop Python 3.3 support from our setup.cfg
Change-Id: I8c8f9222fcf1111e99a943976aae9c5b427f7ee4
Closes-Bug: #1523983
This code is not useful because we have only one version
of watcher db currently and this alembic revision is out
of date compared to the initial schema as of mitaka-1.
Change-Id: Id21c665ff7a600a716e80d112e131a0e13687b41
Some Python class and packages need to be renamed
for a better compliance with the shared terminology
which provides a better understanding of Watcher
objects and components by every contributor.
This patchset is there to change Command to Action
Partially implements: blueprint glossary-related-refactoring
Change-Id: Id38e133fc8b789319c7db5712d3820ecca1bd51d
The Primitive used by the applier is not defined in the glossary.
This patchset start to fix this gap
Change-Id: Ie3fe153fc4c396da5c83425ccdd540910ad33e49
Some Python class and packages need to be renamed
for a better compliance with the shared terminology
which provides a better understanding of Watcher
objects and components by every contributor.
This patchset is there to change command to action_plan
Partially implements: blueprint glossary-related-refactoring
Change-Id: I19a70adeca347ce747a2221b5fc31658139c95a2
Some Python class and packages need to be renamed
for a better compliance with the shared terminology
which provides a better understanding of Watcher
objects and components by every contributor.
This patchset is there to change Meta-Action to Action
Partially implements: blueprint glossary-related-refactoring
Change-Id: Ie67b800332179be93718030ddd7a36ddc76a544c
This patchset add some unit tests on the documentation:
Checking wrapping
Checking trailing spaces
Checking no_cr
Change-Id: I3fa56d3e7dd3218dcd398e6750bdd2fb3a8e75b4
Some Python class and packages need to be renamed
for a better compliance with the shared Terminology
which provides a better understanding of Watcher
objects and components by every contributor.
This patchset is there to change efficiency to efficacy
Partially implements: blueprint glossary-related-refactoring
Change-Id: I4c84192d49a147e0fd406da35e2805143b902331
PEP8 standards call for instance variable names to be written
in the same manner as methods, with underscores separating words.
This fix addresses an instance variable in the DeployPhase class.
As the instance variable seems public, the Java-ish getter and
setter mentioned in the bug report have been removed as well.
Change-Id: I8835315c8cae64665d3ccb321c4066e37a22c467
Closes-Bug: 1522489
main() duplicates code for oslo_log setup, which is first
called within prepare_services(). This patches removes
the duplication call in main()
Change-Id: I712d3733218c18b2eb02d4bf26e54b29ef72a988
Closes-Bug: #1522781
Added new global architecture diagram using Dia tool
and a more detailed description of each component.
Exported this diagram in SVG format.
The source code of the diagram is stored in
/doc/images_src/ folder.
Moved also the architecture.rst file from the /dev
folder to the root folder of the Watcher doc.
Change-Id: I74379390178673dcb6a043967b31e38ca9560bb3
Change ID Ie027df023e6133f3188e57b42846083f28c282bd integrated the oslo_messaging_rabbit configuration into Watcher. This commit is an update
of the Watcher configuration documentation section, to take into account
new parameters for messaging RabbitMQ broker.
Change-Id: I9aa60c7dd264b4e8535e41ae2f98083985b87b0f
As of now, we do not have a single source of truth
when it comes to the terminology describing the various components
Watcher is made of. Hence, this is an attempt to formalize it into
a single document.
Change-Id: Iffbbe9148e53c88e38297fa9e81b8b024cce4099
Today, the watcher Decision Engine is not relying on Ceilometer V2 API
to query the metrics necessary for the optimization algorithm.
This patchset update the documentation to use Ceilometer API with
watcher
Change-Id: I62cf0ea7b1766b00601f3dcbbbfe20b4a9567570
Querying compute.node.* with Ceilometer requires some additional
information in the cluster data model in order to build the
resource_id. This patchset add the attribute hostname and change
the query.
Change-Id: Ifcefcd70a6d0f5967ab4f638ce077e38ef214f64
Closes-Bug: #1521559
as of mitaka, the infra team won't have the resources available to
reasonably test py26, also the oslo team is dropping py26 support from
their libraries. sine we rely on oslo for a lot of our work, and depend
on infra for our CI, we should drop py26 support too.
Change-Id: I8aec07a1149ad7232c3d6db2f3c274ec9ce11a66
Closes-Bug: #1522363
This patchset is there to change the code structure.
The objective is to flatten the project file tree by merging
'api/' and 'framework/' into a single package. This also contains
some tidy ups in package naming (like using only singular nouns).
This should only affect file/folder names and their subsequent
import paths wherever they were used.
Change-Id: Id7b37667c613086d8ef3cd1f367c4219bf026fc7
Since all oslo libs are now using the new versions installed using
pip, there is no need to keep the watcher/openstack/common/ folder.
Implements: blueprint make-watcher-use-graduated-oslo-lib
Change-Id: I9e08b4a50c6b15a4d51a7f53fdd615d6c28fdce7
