PEP8 standards call for instance variable names to be written
in the same manner as methods, with underscores separating words.
This fix addresses an instance variable in the DeployPhase class.
As the instance variable seems public, the Java-ish getter and
setter mentioned in the bug report have been removed as well.
Change-Id: I8835315c8cae64665d3ccb321c4066e37a22c467
Closes-Bug: 1522489
main() duplicates code for oslo_log setup, which is first
called within prepare_services(). This patches removes
the duplication call in main()
Change-Id: I712d3733218c18b2eb02d4bf26e54b29ef72a988
Closes-Bug: #1522781
Added new global architecture diagram using Dia tool
and a more detailed description of each component.
Exported this diagram in SVG format.
The source code of the diagram is stored in
/doc/images_src/ folder.
Moved also the architecture.rst file from the /dev
folder to the root folder of the Watcher doc.
Change-Id: I74379390178673dcb6a043967b31e38ca9560bb3
Change ID Ie027df023e6133f3188e57b42846083f28c282bd integrated the oslo_messaging_rabbit configuration into Watcher. This commit is an update
of the Watcher configuration documentation section, to take into account
new parameters for messaging RabbitMQ broker.
Change-Id: I9aa60c7dd264b4e8535e41ae2f98083985b87b0f
As of now, we do not have a single source of truth
when it comes to the terminology describing the various components
Watcher is made of. Hence, this is an attempt to formalize it into
a single document.
Change-Id: Iffbbe9148e53c88e38297fa9e81b8b024cce4099
Today, the watcher Decision Engine is not relying on Ceilometer V2 API
to query the metrics necessary for the optimization algorithm.
This patchset update the documentation to use Ceilometer API with
watcher
Change-Id: I62cf0ea7b1766b00601f3dcbbbfe20b4a9567570
Querying compute.node.* with Ceilometer requires some additional
information in the cluster data model in order to build the
resource_id. This patchset add the attribute hostname and change
the query.
Change-Id: Ifcefcd70a6d0f5967ab4f638ce077e38ef214f64
Closes-Bug: #1521559
as of mitaka, the infra team won't have the resources available to
reasonably test py26, also the oslo team is dropping py26 support from
their libraries. sine we rely on oslo for a lot of our work, and depend
on infra for our CI, we should drop py26 support too.
Change-Id: I8aec07a1149ad7232c3d6db2f3c274ec9ce11a66
Closes-Bug: #1522363
This patchset is there to change the code structure.
The objective is to flatten the project file tree by merging
'api/' and 'framework/' into a single package. This also contains
some tidy ups in package naming (like using only singular nouns).
This should only affect file/folder names and their subsequent
import paths wherever they were used.
Change-Id: Id7b37667c613086d8ef3cd1f367c4219bf026fc7
Since all oslo libs are now using the new versions installed using
pip, there is no need to keep the watcher/openstack/common/ folder.
Implements: blueprint make-watcher-use-graduated-oslo-lib
Change-Id: I9e08b4a50c6b15a4d51a7f53fdd615d6c28fdce7
The BaseStrategy interface was moved to another location but the
documentation wasn't updated accordingly, so here I updated this
import path.
As an extra, I also updated the description of the Solution which
also had an outdated import path.
Closes-Bug: #1522034
Change-Id: I8cd43e84db6945391db06ec6dfe82ce02eccc7f4
The old 'watcher_messaging' section of the Watcher configuration file
has now been replaced by the more standard oslo.configuration one.
DocImpact
Change-Id: Ie027df023e6133f3188e57b42846083f28c282bd
This should make our 'dummy' strategy available for use.
I also removed all previously defined default goals, which means
that they will have to define it themselves from now on.
This can also be useful for future integration tests.
Change-Id: I6c43eba941022a88851a199b56a6c20f017b9e71
DocImpact
Closes-Bug: #1520178
In several places in Watcher, there are statuses which corresponds
to a status in the respective life cycle. There were used past tense
everywhere, except "SUCCESS" which was written in present tense.
So I searched for all the occurences of this state, and replaced them
with their past tense form.
Change-Id: Ic41def96d1a608da06a1e394e24704d4f06ab32a
Closes-Bug: #1520276
Added the missing super() call in the LaunchActionPlanCommand class
__init__() method, as it was requested.
Change-Id: I6d8cc7880b1e979f94acd3fdd84e3f6d1a90a032
Closes-Bug: #1520521
The objective is to make it more explicit that the 'service' project
is referring to the keystone service.
This changeset also updated the documentation to stay under the
limit of 80 per line.
Change-Id: I22430585e3e8999f27c2c2d48398a70298da9850
Added the missing super() call in the DefaultApplier class
__init__() method, as it was requested.
Change-Id: I58be9671e9635d800d63480043e2e4cd752d45fd
Closes-Bug: #1520524
Default channel used is named 'openstack'. But Watcher AMQP topics are
bound to 'watcher' channel. So, on RCPClient init, we have to set
the channel name to 'watcher' for the target.
Change-Id: Ifdbb187f1ee60f898ef0340e0c037891350ce815
Closes-Bug: #1520599
Following the update of the project requirements, we should now
use the oslo.config namespace of oslo.log when generating ou
Watcher config sample file.
Change-Id: I7a1f3d555534b40c041b7f042f19fae231b7e80c
Closes-Bug: #1518297
This patchset is there to change the code structure.
The objective is to flatten the project file tree by merging
'api/' and 'framework/' into a single package. This also contains
some tidy ups in package naming (like using only singular nouns).
This should only affect file/folder names and their subsequent
import paths wherever they were used.
Change-Id: Ie903ba20ca5cf03b0b42efa60131d1b919b0c2c9
Following https://review.openstack.org/#/c/245903, this patchset
documents the implementation and integration of custom Strategies
with Watcher.
Change-Id: I573758695d67d523834f145824b6f6cfdd8997fe
Update requirements.txt and test-requirements.txt from Global Requirements
defined into openstack/requirements project (stable/liberty).
Change-Id: I9ecbf5a7fb2c38624cc4f52b13515f8af75a4889
Closes-Bug: #1513118
The objective for this is to give the ability to extend the default
set of placement algorithms (i.e. strategies) currently available
in Watcher using Stevedore.
Now, you can add your new strategy as an entry point under the
'[watcher_strategies]' section.
Change-Id: I4aecf629015e41b0389d07e47220333e50bbbe1a
In current implementation is not easy to use ceilometer.
Watcher must query metrics from the Telemetry v2 API to allow an easiest integration with OpenStack components (especially devstack).
blueprint telemetry-integration
Change-Id: Ide515472f1d160925d9f4aabf48c96dea4f6bc05
Configuration file sample must be synchronized with source code updates,
and especially with bug/1516701 fix.
Change-Id: I8773539c88340a4cde0015c7a5c7c7204a47609b
This regression was caused when we upgrade the version of olso.
Unfortunately this issue wasn't picked up with the unit tests as
the cmds doesn't have unit tests yet.
Error message: "watcher-api fail with NoSuchOptError: no such option:debug"
This patchset implements unit tests for:
- 'watcher-api' command
- 'watcher-db-manage' command (and sub-command)
- 'watcher-applier' command
Change-Id: I2bea8aee28dec913ebc45f2824bf474f86652642
